From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id SLpWAd/u9WNzGwAAbAwnHQ (envelope-from ) for ; Wed, 22 Feb 2023 11:30:55 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id cAg7Ad/u9WORbAAA9RJhRA (envelope-from ) for ; Wed, 22 Feb 2023 11:30:55 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A2E739884 for ; Wed, 22 Feb 2023 11:30:54 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=HacgBQbn; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677061854; a=rsa-sha256; cv=none; b=lm1jnZ5qxyKJBBFkwYUP77WlSBqja7gv5nxxZ3p5ROisAiCX1ofXIorZYHSg3mXZwASY6I 4/wjxGqI/vCppdesYcA29IJK4sHwjCF5p+lGquDK3eJBqu0O7fOykA5RBrz2VU+7BQqsgv 2JIvmepnNlHHfniOUBbGk5tGp/otyEIWI7eXD+MngwBlBiYQByqnkZ+huv1vXWw1XEGbwI hHRPk/5InBlVD0lth7mcIz3HvZ/fENT8snesVj1wcfyPkfmSz4tobkP8OhujyhwKNXRuid tbKrvXCCGy13KG/fU88y3q0uy9+dClrw6SiRDPOwiAo27AXeI9+dMrlaKIY9tQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=HacgBQbn; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677061854; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=f+PNP29z/d/dgHw18T0DG9f3Dol5Vx7Tslzi/QtpCHU=; b=ObeOf7Gxl5FTJAmWFDzZSCZNmLvSnh6jdSbn4aURN+pLDn26m0i1sG6J/b8+X8+RcH9lKr obj6V52+vlYu7VNrIGHkRCkHOI9Rs1zlr3frdWlaSNIlPYmG9b+2/Dyjm6D4ecx7Gxb271 a7CUU8mXYqn1s7f+T9UMG2q0B6ZDzjc+47iOZBZ0f7kuT1rQ5M8KVfKf9akLjM+huNmN7m 1EHpPwx0uV+LTCcaGC42AQfkZOEq7A34SOwLCYHq12TiJoCLn+zDncystiOqTBgMRJ978v qGospfszCeuY9DIuxN51SQkmBar5SMKIVWgC8iVdzJ3B45J6Rw1myDcFjXYusQ== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pUmNw-0000MB-JR; Wed, 22 Feb 2023 05:30:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUmNs-0000GM-Iv for emacs-orgmode@gnu.org; Wed, 22 Feb 2023 05:30:00 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUmNq-0003m2-Cn for emacs-orgmode@gnu.org; Wed, 22 Feb 2023 05:30:00 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 252D0240642 for ; Wed, 22 Feb 2023 11:29:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1677061796; bh=3D/5/GjzosxsJIiDZuu+ckxdK+hMnLPddbSyjohuivY=; h=From:To:Cc:Subject:Date:From; b=HacgBQbnAmTzCgsKh1s8GW42AlJeiHmq1Hf8plVKYbC+r84S8HSRraJAWWkN3guxU WsAN7yG5HftRxbKMBvLW1qdNUJPrB67qjZkgWoUgMosZvN5WwhuEhGBig/QEW85k4b lYTatgrdRPXnKkqGA0zVjQGwcXlbvh1/W5J4bIedMmiqJDajv139j0MdXNa2Fxyce1 nq2CyVKjMuDbTZA+sIvd9O1qmgnUmculWqrsMPNQ132HI3RPzgpm1XkPy/Qhl0qlyx c5FNcQGAMdNctstiZcvR+g43g22M/PiA+l9NuaFFlQnfLaHa0LstVwPwHOuxFk5gqt Mzm9xULReQOxg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PMC8M1HJyz9rxK; Wed, 22 Feb 2023 11:29:54 +0100 (CET) From: Ihor Radchenko To: Matt Cc: emacs-orgmode Subject: Re: [PATCH] Async evaluation in ob-shell In-Reply-To: <1866fda933d.cf33745c2396994.7118762013608820270@excalamus.com> References: <186283d230a.129f5feb61660123.3289004102603503414@excalamus.com> <87v8kd8zzw.fsf@localhost> <1863472efe9.10fdd5ba4258906.5972264927968042941@excalamus.com> <87y1p7axpe.fsf@localhost> <1863d69188f.11e078bd1228881.451172865246440158@excalamus.com> <87fsbcbf47.fsf@localhost> <186471d8980.c36aecd0374444.2548279362371712281@excalamus.com> <87sff73r0g.fsf@localhost> <18658639a30.dec640641420614.2364646537016397698@excalamus.com> <87lekwd10z.fsf@localhost> <1866bf50874.bc4ef1a92164564.1238825567948423531@excalamus.com> <87r0ukefzv.fsf@localhost> <1866fda933d.cf33745c2396994.7118762013608820270@excalamus.com> Date: Wed, 22 Feb 2023 10:30:36 +0000 Message-ID: <87sfeyc7qr.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Queue-Id: A2E739884 X-Spam-Score: -11.45 X-Migadu-Spam-Score: -11.45 X-Migadu-Scanner: scn0.migadu.com List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-TUID: GPryFV8CKAkH Matt writes: > I've rewritten the test and updated the patch. Thanks! > +(defun ob-shell-async-chunk-callback (string) > + "Filter applied to results before insertion. > +See `org-babel-comint-async-chunk-callback'." > + (replace-regexp-in-string (concat org-babel-sh-prompt "*") "" string)) Why not using `comint-prompt-regexp'? > +(ert-deftest test-ob-shell/session-async-valid-header-arg-values () > + "Test that session runs asynchronously for certain :async values." > + (let ((session-name "test-ob-shell/session-async-valid-header-arg-values") > + (kill-buffer-query-functions nil)) > + (cl-loop A simple `dolist' would do here. There is no reason to use `cl-loop'. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at