emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-test: Fix zone-dependent miscalculation of days of week
Date: Mon, 03 Jun 2024 21:45:00 -0400	[thread overview]
Message-ID: <87sext32hv.fsf@kyleam.com> (raw)
In-Reply-To: <87y17mm5pz.fsf@localhost>

[ Sorry, I somehow managed to drop the References and In-Reply-to
  headers from my previous reply.  I'll include that message again here
  along with some examples. ]

Ihor Radchenko writes:

> I suspect that the failures are because of your timezone.

Yes, that matches my conclusion too and was what I was trying to convey
in the commit message.

> If my guess is right, there will always be some timezone where a given
> number seconds from epoch is a different day...
> I am not sure how to address this problem.

How about my patch?  Notice that format-time-string is invoked with ZONE
set to t so that TIME is always taken as UTC.

Examples
--------

;;; locale en_US.UTF-8
;; local time zone (Japan in this demo)
(format-time-string "%A %T %z" 259200) => "Sunday 09:00:00 +0900"
;; force UTC
(format-time-string "%A %T %z" 259200 t) => "Sunday 00:00:00 +0000"

;; locale de_BE.UTF-8
;; local time zone
(format-time-string "%A %T %z" 259200) => "Sonntag 09:00:00 +0900"
;; force UTC
(format-time-string "%A %T %z" 259200 t) => "Sonntag 00:00:00 +0000"


  reply	other threads:[~2024-06-04  1:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-01 21:43 [PATCH] org-test: Fix zone-dependent miscalculation of days of week Kyle Meyer
2024-06-03 15:00 ` Ihor Radchenko
2024-06-04  1:45   ` Kyle Meyer [this message]
2024-06-04 13:04     ` Ihor Radchenko
  -- strict thread matches above, loose matches on Subject: below --
2024-06-04  1:08 Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sext32hv.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=yantar92@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).