From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id IPVeBE2DXGdXhwAAe85BDQ:P1 (envelope-from ) for ; Fri, 13 Dec 2024 18:56:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id IPVeBE2DXGdXhwAAe85BDQ (envelope-from ) for ; Fri, 13 Dec 2024 19:56:13 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=laIUvc8k; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1734116172; a=rsa-sha256; cv=none; b=qxSAJkBpkchNHWsnJDM03Qcp7ZWBDS3hVxlPMR8Wl2Q43OFyDoCLCDNedmxH4dgi9ufIrr H40ldpUHmqWtD45GQ24TTcKAh/GydBdEvus4M3Xr9MlAPJ/3mXHu5OyU84uUibvVeQSpc3 C2DSWE/P7ZIFEEd46H3+J/FCMm3vwZNs0boy8yg4S4jC3QNakxDtGPUM6+bbJmLI5KxLYb UCJuN+qcwHFbH1TYVDzO+5wuHBTeruv8pvkUCsZtZucY1DntJhbr2bLOxwfoWiQjHTXXdX EglWc7p85/BJx7+JInIP3m1ep2uZRmwjsM6+uneGzslBkv15egy6B3XYh1y/8A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=laIUvc8k; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1734116172; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=qP5B43mHZJfRgz9aGMR+B4Lh3RMVHXFmGFlunKFXdOk=; b=qV/ZQ/JRuUmYfbC9I7xotFGZ9D06Hh0/VTuzfODyuvK+lpdl1XlX+5VAiNdr2uqQTkv4rQ ALiSViqeYOtGVlwf1/RD9wBaf2cbRNObxqWKrSnE1PmkoruiFBN+teYQJwZhy0hLfUZyRQ y8O+ArlpShTnIVDlqjjSzS7PZxspYUvK9ioVRlAoYupFnFIuVmyHaRa3tRd1GXivtO3Woc BzR3ZSbNcNXQb3ECEPdhRA/I+xDMAJPQQTImgcndbDmXB5ucPt4Fg2xnhNYev93sBhQH1P gxT+zzqm0GuA61PESxTgdG+vRlAj1vhYRrC9t79Y2pYF0uqZ215IKWIWfpU0xg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5A13D5C515 for ; Fri, 13 Dec 2024 19:56:12 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tM9j0-0006uN-AD; Fri, 13 Dec 2024 12:45:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tM9iy-0006oy-4u for emacs-orgmode@gnu.org; Fri, 13 Dec 2024 12:45:12 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tM9iu-0004PH-IU for emacs-orgmode@gnu.org; Fri, 13 Dec 2024 12:45:11 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id D5A8F240027 for ; Fri, 13 Dec 2024 18:45:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1734111905; bh=E/lLeE4oQZ/0pZ71SIACJ85hCYrU+JhY8C4Nd4kblQA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=laIUvc8k3fJuc6PwLTt9YexwidYs0QC1skS4pOBC97nSiN6AVje5u/xXntdrUehyN CSjiPagMqh+LhAYOYe8xnrxkBQtNCVEsyV/gZDK/RBt36B/DnUxq6flG19IkmT4/b5 IQKjRFzgmUKMBfBkkeoXQL5Vp7EHyqkRboTYEvxnHQascCOWNLy6comBu4kfGjT3z9 lwCwMaawFKvjMekR1xyCg1YVAlpy9R26MOZuQSZyGLHmyY6I9hQwqDPuWEzZcA8jbU W/Lm5yVYq/T9PMHy4El3RDlk1XsYwN3UDs2jvdZR5bfjSbjRJr9kml5KCV8SwDc0WW xBLUFGyzVEsMQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Y8xYs2SlSz6tw2; Fri, 13 Dec 2024 18:45:05 +0100 (CET) From: Ihor Radchenko To: Phil Estival Cc: Org Mode List Subject: Re: [PATCH] ob-sql: session In-Reply-To: <646f7d12-a3d1-4a7c-83e2-5eecd7ca6817@7d.nz> References: <646f7d12-a3d1-4a7c-83e2-5eecd7ca6817@7d.nz> Date: Fri, 13 Dec 2024 17:46:34 +0000 Message-ID: <87seqrh3wl.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 5A13D5C515 X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -9.11 X-Spam-Score: -9.11 X-TUID: fqAcFbTTcmqr Phil Estival writes: > From Org 9.7.16, > this patch modifies ob-sql to add support for session. > - reintroduces sqlite in ob-sql (even if there is ob-sqlite.el) > - limitation: no line number in session (a block is provided > on one prompt line) > - tests: some generic macro for checking results could go up/out > of this test set. Thanks a lot for the patch and for adding yourself as a maintainer! Before I start a more detailed preview, may you please: 1. Rebase your changes onto main (development) branch. This is where the new features are added. See https://orgmode.org/worg/org-maintenance.html#branches 2. Get rid of whitespace-only commits. See https://orgmode.org/worg/org-contribute.html#orge765e69 3. If possible, add a commit message to each patch in the series. It will make things easier for me during the review, as I will have an idea about the general purpose of each patch in the series. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at . Support Org development at , or support my work at