Latest Speed Keys "D" and "U" behavior

Latest Speed Keys "D" and "U" behavior

[marcowahlsoft]

Hi,

In the past speed key "D" (analog "U") on a headline moved the whole
subtree down.  In the latest org-mode version the effect of speed key
"D" is to move the headline (and only just the headline) down.  BTW this
change of behavior is due to a change in `org-shiftmetadown' AFAICT.

Is the user who wants the old behavior back supposed to configure
`org-speed-commands-user' with `org-metadown'?

Personal note: I used those keys a lot as I can clearly observe since
their functionality changed.  And I vote for giving the speed keys "D"
and "U" back their old functionality.


Best regards,  Marco
-- 
Marco Wahl -- Freelancer

Re: Latest Speed Keys "D" and "U" behavior

[Matt Lundin]

[-- Attachment #1: Type: text/plain, Size: 1088 bytes --]

marcowahlsoft@gmail.com writes:

> Hi,
>
> In the past speed key "D" (analog "U") on a headline moved the whole
> subtree down.  In the latest org-mode version the effect of speed key
> "D" is to move the headline (and only just the headline) down.  BTW this
> change of behavior is due to a change in `org-shiftmetadown' AFAICT.
>
> Is the user who wants the old behavior back supposed to configure
> `org-speed-commands-user' with `org-metadown'?
>
> Personal note: I used those keys a lot as I can clearly observe since
> their functionality changed.  And I vote for giving the speed keys "D"
> and "U" back their old functionality.

I can confirm this bug. I consider it an undesired change since when one
is on a headline, one rarely wants to move only the headline up and
down. E.g., turning...

* TODO Headline
  :LOGBOOK:
  CLOCK: [2014-06-23 Mon 09:34]--[2014-06-23 Mon 09:35] =>  0:01
  :END:

...into...

  :LOGBOOK:
* TODO Headline
  CLOCK: [2014-06-23 Mon 09:34]--[2014-06-23 Mon 09:35] =>  0:01
  :END:

...does not make much sense. Below is a patch to fix it.

Best,
Matt


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-speedkeys-to-move-subtrees-up-and-down.patch --]
[-- Type: text/x-diff, Size: 1162 bytes --]

From faf34bdedcae517e68c50ae9a77ee8086588dfe3 Mon Sep 17 00:00:00 2001
From: Matt Lundin <mdl@imapmail.org>
Date: Mon, 23 Jun 2014 09:17:54 -0500
Subject: [PATCH] Fix speedkeys to move subtrees up and down

* lisp/org.el: (org-speed-commands-default) Org speed keys were not
  updated to reflect the recent changes to org-shiftmetaup and
  org-shiftmetadown. As a result the default bindings for speedkeys
  "U" and "D" were destructive, since they moved only single
  lines. Binding them to org-metaup and org-metadown fixes the
  problem.

Thanks to Marco Wahl for reporting the problem:
http://permalink.gmane.org/gmane.emacs.orgmode/87873
---
 lisp/org.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index c82fd06..2b57fc0 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -19523,8 +19523,8 @@ boundaries."
     ("s" . org-narrow-to-subtree)
     ("=" . org-columns)
     ("Outline Structure Editing")
-    ("U" . org-shiftmetaup)
-    ("D" . org-shiftmetadown)
+    ("U" . org-metaup)
+    ("D" . org-metadown)
     ("r" . org-metaright)
     ("l" . org-metaleft)
     ("R" . org-shiftmetaright)
-- 
2.0.0

Re: Latest Speed Keys "D" and "U" behavior

[Bastien]

Hi Matt,

Matt Lundin <mdl@imapmail.org> writes:

> I can confirm this bug.

Applied in master, with a slightly modified changelog, thanks

-- 
 Bastien

Re: Latest Speed Keys "D" and "U" behavior

[Bastien]

Hi Marco,

marcowahlsoft@gmail.com writes:

> Is the user who wants the old behavior back supposed to configure
> `org-speed-commands-user' with `org-metadown'?

Nope -- reporting weird new behavior like you did will do :)

Thanks for this,

-- 
 Bastien