emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Matt Lundin <mdl@imapmail.org>
To: marcowahlsoft@gmail.com
Cc: emacs-orgmode@gnu.org
Subject: Re: Latest Speed Keys "D" and "U" behavior
Date: Mon, 23 Jun 2014 09:38:03 -0500	[thread overview]
Message-ID: <87r42fpu7o.fsf@fastmail.fm> (raw)
In-Reply-To: <8438ewjdcc.fsf@tm6592.fritz.box> (marcowahlsoft@gmail.com's message of "Mon, 23 Jun 2014 09:26:43 +0200")

[-- Attachment #1: Type: text/plain, Size: 1088 bytes --]

marcowahlsoft@gmail.com writes:

> Hi,
>
> In the past speed key "D" (analog "U") on a headline moved the whole
> subtree down.  In the latest org-mode version the effect of speed key
> "D" is to move the headline (and only just the headline) down.  BTW this
> change of behavior is due to a change in `org-shiftmetadown' AFAICT.
>
> Is the user who wants the old behavior back supposed to configure
> `org-speed-commands-user' with `org-metadown'?
>
> Personal note: I used those keys a lot as I can clearly observe since
> their functionality changed.  And I vote for giving the speed keys "D"
> and "U" back their old functionality.

I can confirm this bug. I consider it an undesired change since when one
is on a headline, one rarely wants to move only the headline up and
down. E.g., turning...

* TODO Headline
  :LOGBOOK:
  CLOCK: [2014-06-23 Mon 09:34]--[2014-06-23 Mon 09:35] =>  0:01
  :END:

...into...

  :LOGBOOK:
* TODO Headline
  CLOCK: [2014-06-23 Mon 09:34]--[2014-06-23 Mon 09:35] =>  0:01
  :END:

...does not make much sense. Below is a patch to fix it.

Best,
Matt


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-speedkeys-to-move-subtrees-up-and-down.patch --]
[-- Type: text/x-diff, Size: 1162 bytes --]

From faf34bdedcae517e68c50ae9a77ee8086588dfe3 Mon Sep 17 00:00:00 2001
From: Matt Lundin <mdl@imapmail.org>
Date: Mon, 23 Jun 2014 09:17:54 -0500
Subject: [PATCH] Fix speedkeys to move subtrees up and down

* lisp/org.el: (org-speed-commands-default) Org speed keys were not
  updated to reflect the recent changes to org-shiftmetaup and
  org-shiftmetadown. As a result the default bindings for speedkeys
  "U" and "D" were destructive, since they moved only single
  lines. Binding them to org-metaup and org-metadown fixes the
  problem.

Thanks to Marco Wahl for reporting the problem:
http://permalink.gmane.org/gmane.emacs.orgmode/87873
---
 lisp/org.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index c82fd06..2b57fc0 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -19523,8 +19523,8 @@ boundaries."
     ("s" . org-narrow-to-subtree)
     ("=" . org-columns)
     ("Outline Structure Editing")
-    ("U" . org-shiftmetaup)
-    ("D" . org-shiftmetadown)
+    ("U" . org-metaup)
+    ("D" . org-metadown)
     ("r" . org-metaright)
     ("l" . org-metaleft)
     ("R" . org-shiftmetaright)
-- 
2.0.0


  reply	other threads:[~2014-06-23 14:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-23  7:26 Latest Speed Keys "D" and "U" behavior marcowahlsoft
2014-06-23 14:38 ` Matt Lundin [this message]
2014-06-23 14:55   ` Bastien
2014-06-23 14:56 ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r42fpu7o.fsf@fastmail.fm \
    --to=mdl@imapmail.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=marcowahlsoft@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).