From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] Fix org-clock-load Date: Tue, 20 Dec 2016 18:01:57 +0100 Message-ID: <87r352zg8q.fsf@nicolasgoaziou.fr> References: <8760mfcx6d.fsf@fastmail.fm> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49105) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cJNnY-00079s-A0 for emacs-orgmode@gnu.org; Tue, 20 Dec 2016 12:02:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cJNnU-0002pR-IJ for emacs-orgmode@gnu.org; Tue, 20 Dec 2016 12:01:56 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:58503) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cJNnU-0002oy-C6 for emacs-orgmode@gnu.org; Tue, 20 Dec 2016 12:01:52 -0500 Received: from saiph (unknown [IPv6:2a03:a0a0:0:4301::b3c]) (Authenticated sender: mail@nicolasgoaziou.fr) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id E7B791720EB for ; Tue, 20 Dec 2016 18:01:50 +0100 (CET) In-Reply-To: <8760mfcx6d.fsf@fastmail.fm> (Matt Lundin's message of "Mon, 19 Dec 2016 17:32:26 -0600") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Org Mode Hello, Matt Lundin writes: > Since commit fda64f1ae2110175662b52daa3a5ec0f967f0c0d on November 6, > org-clock-load no longer restores clocks in org-clock-persist-file. The > contents of the file look like this: > > (setq org-clock-stored-history '(("/home/matt/org/inbox.org" . 39479) ("/home/matt/org/reading.org" . 63478))) > > The files both exist; the position information is correct; and > org-clock-persist is t. And yet after calling org-clock-load, > org-clock-history, org-clock-loaded, and org-clock-stored-history remain > nil. > > The problem, it seems, is that the logic/order of the if statement was > reversed in the commit above. The attached patch should fix the issue. Applied. Thank you. Regards, -- Nicolas Goaziou