From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Lorenzo Bolla <lbolla@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: Caching org-publish-find-date [8.2.10 (release_8.2.10 @ /opt/emacs/lisp/org/)]
Date: Wed, 27 Dec 2017 23:48:57 +0100 [thread overview]
Message-ID: <87r2rfyeg6.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CADjgTRzfekmjgsdVY3+bjZ0AS9qHKD2X6=y+F6EgZoLxbqNArg@mail.gmail.com> (Lorenzo Bolla's message of "Wed, 27 Dec 2017 16:54:49 +0000")
Hello,
Lorenzo Bolla <lbolla@gmail.com> writes:
> When using `org-publish-project` I noticed that generating a sitemap
> sorted (anti-)chronologically is very slow. It turns out that the
> slowness is due to the sorting of sitemap entries, which calls
> `org-publish-find-date` during the comparison. But
> `org-publish-find-date` is not cached therefore it is called over and
> over for each file during the sorting process.
> By contrast, `org-publish-find-title` is cached and sorting
> alphabetically is faster.
>
> To test this assumption, I've modified `ox-publish.el` to cache
> `org-publish-find-date`, too, obtaining a substantial speed-up:
>
> (defun org-publish-find-date (file)
> (or
> (org-publish-cache-get-file-property file :date nil t)
> (let ((date (org-publish-find-date-uncached file)))
> (org-publish-cache-set-file-property file :date date)
> date)))
>
> (defun org-publish-find-date-uncached (file)
> "Find the date of FILE in project.
> This function assumes FILE is either a directory or an Org file.
> If FILE is an Org file and provides a DATE keyword use it. In
> any other case use the file system's modification time. Return
> time in `current-time' format."
> ...
>
> Is there a reason why we should not cache the date of a file, in the
> same way as we cache its title?
That's post-mature optimization. When only cache results of a function
when it is reported as horribly slow.
I added a cache for `org-publish-find-date' in master branch. Thank you.
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2017-12-27 22:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-27 16:54 Bug: Caching org-publish-find-date [8.2.10 (release_8.2.10 @ /opt/emacs/lisp/org/)] Lorenzo Bolla
2017-12-27 22:48 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2rfyeg6.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=lbolla@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).