From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: inherit priority
Date: Mon, 08 Jan 2018 14:16:45 +0100
Message-ID: <87r2r05w3m.fsf@nicolasgoaziou.fr>
References: <a607e521-4971-6c22-94d8-c8b170ef836d@gmail.com>
	<87wp0ymxgy.fsf@nicolasgoaziou.fr>
	<92a7a7a4-a992-86f5-eb8f-2381213ad32f@gmail.com>
	<87o9mam43l.fsf@nicolasgoaziou.fr>
	<c8c0ac24-0822-12a3-fd2e-df3c1dc949ac@gmail.com>
	<87tvw0g444.fsf@nicolasgoaziou.fr>
	<cc99c4a6-4c7d-19e1-ffef-1157deb96ab2@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34719)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1eYXIJ-0006br-Ui
	for emacs-orgmode@gnu.org; Mon, 08 Jan 2018 08:16:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1eYXIJ-0007wK-3C
	for emacs-orgmode@gnu.org; Mon, 08 Jan 2018 08:16:51 -0500
Received: from relay3-d.mail.gandi.net ([2001:4b98:c:538::195]:39085)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1eYXII-0007tE-Sj
	for emacs-orgmode@gnu.org; Mon, 08 Jan 2018 08:16:51 -0500
In-Reply-To: <cc99c4a6-4c7d-19e1-ffef-1157deb96ab2@gmail.com> (Jesse Johnson's
	message of "Sun, 7 Jan 2018 14:47:20 -0800")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Jesse Johnson <bbuknight@gmail.com>
Cc: emacs-orgmode@gnu.org

Hello,

Jesse Johnson <bbuknight@gmail.com> writes:

> I am trying to determine the functions I need to add / update to
> respect priority inheritance.
>
> I see that org-show-priority would need to be updated,

Correct, but that would be a minor change.

> and likely
> a new function, say org-get-priority-with-inheritance, should
> supplement org-get-priority.

I think you need to change `org-get-priority' signature. You can remove
the string argument and possibly add an optional argument: a buffer
position. It should handle inheritance without any additional function,
if a global variable, e.g., `org-priority-use-inheritance' is non-nil.

Note that you can already achieve inheritance by setting
`org-get-priority-function' to a function that searches priority cookies
among ancestors of the current headline.

> However, I can't figure out where org-colview is getting the priority
> from.

>From `org-entry-get' -> `org-entry-properties'.

I don't think there's any change involved in "org-colview.el".

> I also don't know where sorting is considering priority.
>
> Help with pointing me in the right direction for either of those would
> be much appreciated! Also let me know if other things touching
> priority need updating for inheritance.

You should start with `org-get-priority'. Most things are going to work
once it is updated.

Regards,

-- 
Nicolas Goaziou