From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] ob-sql.el: Improve Oracle connection and usage for
 ob-sql.
Date: Fri, 16 Mar 2018 23:03:00 +0100
Message-ID: <87r2oj8yqz.fsf@nicolasgoaziou.fr>
References: <871sgt2fk3.fsf@killashandra.ballybran.fr>
	<87po488k1l.fsf@nicolasgoaziou.fr>
	<87po47wy7j.fsf@killashandra.ballybran.fr>
	<87a7van5eq.fsf@nicolasgoaziou.fr>
	<87bmfpdw74.fsf@killashandra.ballybran.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46625)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1ewxRR-0001zI-UG
	for emacs-orgmode@gnu.org; Fri, 16 Mar 2018 18:03:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1ewxRN-00019l-25
	for emacs-orgmode@gnu.org; Fri, 16 Mar 2018 18:03:13 -0400
Received: from relay9-d.mail.gandi.net ([217.70.183.199]:43659)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1ewxRM-00017W-SL
	for emacs-orgmode@gnu.org; Fri, 16 Mar 2018 18:03:08 -0400
In-Reply-To: <87bmfpdw74.fsf@killashandra.ballybran.fr> ("Pierre
	=?utf-8?Q?T=C3=A9choueyres=22's?= message of "Thu, 15 Mar 2018 19:34:39
	+0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Pierre =?utf-8?Q?T=C3=A9choueyres?= <pierre.techoueyres@free.fr>
Cc: emacs-orgmode@gnu.org

Hello,

pierre.techoueyres@free.fr (Pierre T=C3=A9choueyres) writes:

> So I attached two patches:
> - the first (0001-ORG-NEWS-...) correct the example in order to match to =
the code,
> - the second (0001-ob-sql.el...) correct the codein order to match to the=
 example.
>
> Personnaly I prefer the last as it match better with the habits of
> thoses who uses Oracle's products (We talk almost ever in term of
> database than in term of servers).
>
> But it's up to you.

I applied the second patch, with a slight refactoring.

Thank you.

Regards,

--=20
Nicolas Goaziou