From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [BUG][ODT] ODT_STYLES_FILE not read as a list Date: Sun, 04 Nov 2018 23:05:31 +0100 Message-ID: <87r2g08pn8.fsf@nicolasgoaziou.fr> References: <8736snjh60.fsf@christianmoe.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35862) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gJQlE-0007qJ-BZ for emacs-orgmode@gnu.org; Sun, 04 Nov 2018 17:20:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gJQWk-00010r-R7 for emacs-orgmode@gnu.org; Sun, 04 Nov 2018 17:05:55 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:41317) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gJQWg-00006d-Ob for emacs-orgmode@gnu.org; Sun, 04 Nov 2018 17:05:47 -0500 In-Reply-To: <8736snjh60.fsf@christianmoe.com> (Christian Moe's message of "Tue, 30 Oct 2018 21:47:19 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Christian Moe Cc: emacs-orgmode@gnu.org Hello, Christian Moe writes: > It seems the ODT exporter currently fails to read the ODT_STYLES_FILE > option as a list, as in this example from the manual > ([[info:org#Applying custom styles]]): > > #+ODT_STYLES_FILE: ("/path/to/file.ott" ("styles.xml" "image/hdr.png")) > > This is needed if you want a complex style with e.g. an image in the > header. > > Exporting this causes an "Invalid specification of styles.xml file" > error on my recent ELPA version. The problem seems to be that the option > is treated as a string and never tested to see if it contains a list. > > To reproduce the problem, place the attached documents > odt-styles-test.org and odt-test-styles.odt in the same directory, then > export odt-styles-test.org to ODT. The result should have a unicorn in > the letterhead. > > The below quick-and-dirty patch seems to fix it, but I'm sure there's a > better approach. Thank you. I applied your patch with an additional check: the value should be enclosed within round brackets. Regards, -- Nicolas Goaziou