emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [BUG][ODT] ODT_STYLES_FILE not read as a list
@ 2018-10-30 20:47 Christian Moe
  2018-10-30 20:49 ` Christian Moe
  2018-11-04 22:05 ` Nicolas Goaziou
  0 siblings, 2 replies; 12+ messages in thread
From: Christian Moe @ 2018-10-30 20:47 UTC (permalink / raw)
  To: emacs-orgmode

Hi,

It seems the ODT exporter currently fails to read the ODT_STYLES_FILE
option as a list, as in this example from the manual
([[info:org#Applying custom styles]]):

  #+ODT_STYLES_FILE: ("/path/to/file.ott" ("styles.xml" "image/hdr.png"))

This is needed if you want a complex style with e.g. an image in the
header.

Exporting this causes an "Invalid specification of styles.xml file"
error on my recent ELPA version. The problem seems to be that the option
is treated as a string and never tested to see if it contains a list.

To reproduce the problem, place the attached documents
odt-styles-test.org and odt-test-styles.odt in the same directory, then
export odt-styles-test.org to ODT. The result should have a unicorn in
the letterhead.

The below quick-and-dirty patch seems to fix it, but I'm sure there's a
better approach.

*** /home/cm/.emacs.d/elpa/org-20180924/ox-odt.el	2018-09-27 13:38:07.644922989 +0200
--- /home/cm/Downloads/ox-odt.el	2018-10-30 21:18:44.827975243 +0100
***************
*** 1360,1365 ****
--- 1360,1368 ----
    (let* ((styles-file (plist-get info :odt-styles-file))
  	 (styles-file (and (org-string-nw-p styles-file)
  			   (org-trim styles-file)))
+ 	 ;; Try reading it as a list
+ 	 (styles-expr (car (read-from-string styles-file)))
+ 	 (styles-file (if (listp styles-expr) styles-expr styles-file)
  	 ;; Non-availability of styles.xml is not a critical
  	 ;; error. For now, throw an error.
  	 (styles-file (or styles-file

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2018-11-19 22:58 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-30 20:47 [BUG][ODT] ODT_STYLES_FILE not read as a list Christian Moe
2018-10-30 20:49 ` Christian Moe
2018-11-04 22:05 ` Nicolas Goaziou
2018-11-05  8:49   ` Christian Moe
2018-11-06 15:18     ` L.C. Karssen
2018-11-06 15:35       ` Christian Moe
2018-11-06 16:15         ` L.C. Karssen
2018-11-07  8:28           ` Christian Moe
2018-11-07 15:32             ` L.C. Karssen
2018-11-10  8:16               ` Nicolas Goaziou
2018-11-19 17:21                 ` L.C. Karssen
2018-11-19 22:58                   ` Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).