From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 2AbgGCMFq2MN0wAAbAwnHQ (envelope-from ) for ; Tue, 27 Dec 2022 15:45:55 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id aBPaGCMFq2NycQAA9RJhRA (envelope-from ) for ; Tue, 27 Dec 2022 15:45:55 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 16671114A3 for ; Tue, 27 Dec 2022 15:45:55 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pABCv-0002Mh-He; Tue, 27 Dec 2022 09:45:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pABCr-0002MR-Ta for emacs-orgmode@gnu.org; Tue, 27 Dec 2022 09:45:32 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pABCn-0004CI-PP for emacs-orgmode@gnu.org; Tue, 27 Dec 2022 09:45:27 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 2E9EF240026 for ; Tue, 27 Dec 2022 15:45:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1672152323; bh=9XxhnMa13c1BWvbYLQLudiFBex+jiMKd+EsPNwSKjeI=; h=From:To:Cc:Subject:Date:From; b=UKY7LWc7kbJ51BQ93b+rRAXXRNNnF90DHuGyRPUXVT7WgP6XliV1b6iNll3Wo2yZz Wj9l2DC5S2GsLE/jaoIo7Ljk8uHai4vIyMh8uIskcyuJpAyesat/j2l3nfLxbdVSnS X/UuimKNpzQodKCAvW8zAbinDamuTMbX/Glqneu8QFLdh763MX9z+ULoncc5MkfN63 BBPd0OmtGLHdG5VJ0b7wxIrIMv/my3eeCwLmXg1cVOINn5j9EJHUD1J9JqF+lKQ4eS sCkr+rUW6g9jbRE5NCVArlM5LxOosMYTPy9af6YROWoH1ad5uKfuaO+jPu3sUehSwC l+r8ZcU4DAgrw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NhHWN0Y1Tz6tm9; Tue, 27 Dec 2022 15:45:19 +0100 (CET) From: Ihor Radchenko To: Leo Butler Cc: Org Mode Mailing List Subject: Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects In-Reply-To: <87fsd7wolt.fsf@t14.reltub.ca> References: <87mt92elyy.fsf@t14.reltub.ca> <87mt9128sz.fsf@localhost> <87zgd1b4rn.fsf_-_@t14.reltub.ca> <8735asbtfe.fsf@localhost> <87pmdvamwf.fsf@t14.reltub.ca> <87bkpaguy3.fsf@localhost> <87leocuhpg.fsf@t14.reltub.ca> <87359esah2.fsf@localhost> <87cz8ifioa.fsf@localhost> <87sfh9vukl.fsf@localhost> <87fsd7wolt.fsf@t14.reltub.ca> Date: Tue, 27 Dec 2022 14:45:12 +0000 Message-ID: <87r0wk29dz.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1672152355; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=kIp5cOaHSKx1JyCcHC5pMCNPCjHpgLU5noVWFxdHrGE=; b=jT+MomZk1uzBv5Fxug9rtRQWeZPvGBFzdrmwsDcy3k8d8d2cdGyJSdXIjFqb1G0V6lm7gq +6gexaaKgth2W8hmODal0/f6HbH0q8iPOUSQ7esWdKFS5deVQR9bH0TKXiNUWModrwjQMI 4iljQtSvm6dBrMKCt6SNzwjJlY22OTfRTjdBARleH6h0JkoAlhRvh/IDV9GlOMK4P30Qef fxCSvW71CgsSj89HvP+e8h6e6yrCHNU/i6hHjlzlQhGWj/M7WcEtzSKg15Urmy+28mhogm 1TQUER1IDQUBUsWy4kJ/xDXCUhBeyWB3ukPZ48GBztRMT03poxEKcQn0V+kICg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=UKY7LWc7; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1672152355; a=rsa-sha256; cv=none; b=i8+8T+iQTzdsp4pW3+XnyYsubvSiSRCOI0vouHkzPVLR+hPMUS+1yOyXEV08Agq0adexT9 aB6wsW5ADLRXeYE3C47oUgJITr8PWBmwWJpYUDQRLNwHd1P570u5vZRoteQST/aeOZRxme I4ecawphtNvjfXIbuUHnSBCfB7rH6p3dsmjHN6pcSSp0O4axNEf9s50sLTrY8yA39VrUuu XD6BHait4kihIPhd1ZHHdIQNWco6ZOQcix++6b5WWqO9u4DsxxD6EEjO45RaQg9IsqVIN+ muby9xedvuxtFSeKqJNymT2q9Mf3lCcwRFny8Nh1d62H5u4/5wX0bfLJ5H6X1Q== X-Spam-Score: -4.47 X-Migadu-Queue-Id: 16671114A3 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=UKY7LWc7; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -4.47 X-TUID: Eu8/t+XnmP9x Leo Butler writes: >> Note that the tests are failing only partially. The graphics file does >> get created, but it has 0 size for some reason. Maybe something to do >> with non-graphical CI environment. > > There is a race condition between writing the contents of the graphics > file to disk and emacs checking the file size. My guess is that this is > causing the problem (and that the same failure applies for emacs-2{6,7}, > since only the emacs-28 reports the exact test failure). Maybe we can just add several `sleep-for' calls to the test? >> I disabled the tests for the time being until we figure out what is >> going on. >> >> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=a29103a78 > > That's pretty crude. Here are a couple thoughts: > > - Is there a way to detect that the tests are running in this CI > environment? We could use that to skip the file-size test selectively. > - Alternatively, we could remove the file-size test entirely. That's temporary solution to not make CI flood me with failure emails several times a day. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at