From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id QHT6D+3Dr2ZCWQEA62LTzQ:P1 (envelope-from ) for ; Sun, 04 Aug 2024 18:09:49 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id QHT6D+3Dr2ZCWQEA62LTzQ (envelope-from ) for ; Sun, 04 Aug 2024 20:09:49 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=NErrluh6; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1722794989; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=57qfge5LzagfZgvp01Ib77SGRffFZtDCODJY4sqo25g=; b=sIfysACw1Jtb/Xv64LDarvMHZfs+2u/r5WQ5LEpqYCNFcH6yJlT/yjIsPoHZLPluUdZa2d i64kq7VLVIXv0E1A84MumH3WqpNBaHfgdVFNDdaGXoe/vezdDlo8D+5fBp0zXYhrBrTRfd VaRrXqvJxw0P//1pmbQ8yKF14iZoFkYnZ4tgxgTe+2cliWtuS060Tos2vY60CrLRAlaXXw uqlvFKK+YdJHtQPJk5qtrF4H08giPxLfWRN+1z/2uD3gW1Ppvygt9QEPMZZDGmxF7xRYz/ aZGDoH9vexOTz/fFVqNiXc0/RHMSAEKMTIPFiyTPTw2/Ri+nlhDgi5jPOyE88g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=NErrluh6; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1722794989; a=rsa-sha256; cv=none; b=QEoj32+1dKdw7SbxmAJHH8bFbrJGIXXCPOlH0o29hObY+o+zJkMzlhM19Z50YfK3pWXQ5D Cigx/hz4C0uRCfDd3JNhVrLvYacM/kWNSqFB2CjqsiftjxsEVUzzj6ARkiq0JmGIxjgjDI 9gACKyC73VO9TCe4ROI1aPsxw+uHs8clRXNHPkWgdkHuftK+udvBraScucNm83hkUBLYA6 Sk82ykRvnVp4lkTysFyJ1qmJPZ5lBaauhtJJiYxFQSAIMoHotTy5Vtcs8tAKqlq3KzlZUw guED8+OxnYyrm4V6rbPU0x59Dv3w/n2uCPpcf5uyGH/ZVT4X83j1iXVEYDJSYA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1C40071403 for ; Sun, 4 Aug 2024 20:09:48 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1safaQ-0007VA-T8; Sun, 04 Aug 2024 14:04:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1safaP-0007Uv-8t for emacs-orgmode@gnu.org; Sun, 04 Aug 2024 14:04:05 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1safaN-0007K4-47 for emacs-orgmode@gnu.org; Sun, 04 Aug 2024 14:04:05 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id C7C57240027 for ; Sun, 4 Aug 2024 20:03:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1722794639; bh=F2hRtvxydgHYw0w2e+Qm0BaECm68WCvlamxQReSs8cM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=NErrluh662/y2BEblVZ9ejjBBerxYFrZYcsRmLl405TaxZWf0nhz7PEwCtKURjNI2 LETzOGx+WQVfyyoKYAsl2RrOYJ2PdaGLdXFdvemelWtiRCVQm7ljPgxRWVDb+iklBv Agq+LgcJLgtXnMoHxR0Oz1Iy12ozBjq9ScTZc51tSn785W48uQB+30TNo+X+tBZOP0 tkZturNSQOW+kbYZdXZo/0tLmgkCOc6iDrgxdK/qUMm5xHYonRr85JkDWqxvyd3N2P K/O7Jw/Yl4kuDkSkIwEV80m9TSbOYXKP5amS5Q4jXNpWkPcqXZnGMvMfTAQDBCEv08 OpXFo8BGQ60gQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4WcSB70mxVz9rxM; Sun, 4 Aug 2024 20:03:59 +0200 (CEST) From: Ihor Radchenko To: solodov@gmail.com Cc: emacs-orgmode@gnu.org Subject: Re: [BUG] org-cancel-repeater fails depending on position of repeater [9.6.15 (release_9.6.15 @ /opt/homebrew/Cellar/emacs-plus@29/29.4/share/emacs/29.4/lisp/org/)] In-Reply-To: References: Date: Sun, 04 Aug 2024 18:05:15 +0000 Message-ID: <87r0b4duzo.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -9.65 X-Migadu-Queue-Id: 1C40071403 X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -9.65 X-TUID: iJwS68zNhTkS solodov@gmail.com writes: > Minimal test file: > > * test > DEADLINE: <2024-08-02 Fri> SCHEDULED: <2024-07-29 Mon +1d> > > After M-x org-cancel-repeater, repeater is still there: > > * test > DEADLINE: <2024-08-02 Fri> SCHEDULED: <2024-07-29 Mon +1d> Confirmed. That's true, but I am not sure if it is a bug or just an inaccuracy in the documentation. The accurate documentation of what `org-cancel-repeater' does is: Cancel a repeater in the first active timestamp in the heading by setting its numeric value to zero. If there is no repeater in the first timestamp, do nothing. So, it just removes a repeater in the first timestamp. On the other hand, looking into git history, I see that the reason why this function was originally introduced (in 1eb03c8c87) is to prevent `org-todo' from switching an item marked DONE back to TODO when there are _any_ (`org-get-repeat') repeaters inside heading. So, it will follow the original intention to change the function to nullify _all_ the repeaters, not just the one in the first timestamp. What I am leaning to is to change `org-cancel-repeater' to work on all the _active_ timestamps inside the heading and introduce an optional prefix argument to only change first timestamp with non-zero repeater. WDYT? -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at