From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: org-mobile-push and MobileOrg compatibility issue
Date: Sat, 05 Sep 2015 10:45:51 +0200
Message-ID: <87pp1xjlts.fsf@nicolasgoaziou.fr>
References: <CAMruYDRjAs0xFPcBXEkt7w2vOQdToCBzQrN65J+MPChORbWdzg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51838)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1ZY954-0000U2-Qb
	for emacs-orgmode@gnu.org; Sat, 05 Sep 2015 04:44:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1ZY953-0005h0-UF
	for emacs-orgmode@gnu.org; Sat, 05 Sep 2015 04:44:14 -0400
Received: from relay3-d.mail.gandi.net ([2001:4b98:c:538::195]:58812)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1ZY953-0005gu-OE
	for emacs-orgmode@gnu.org; Sat, 05 Sep 2015 04:44:13 -0400
In-Reply-To: <CAMruYDRjAs0xFPcBXEkt7w2vOQdToCBzQrN65J+MPChORbWdzg@mail.gmail.com>
	(Vamsi Vytla's message of "Fri, 04 Sep 2015 22:28:33 +0000")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Vamsi Vytla <vamsi.vytla@gmail.com>
Cc: gordienkos@gmail.com, emacs-orgmode@gnu.org

Hello,

Vamsi Vytla <vamsi.vytla@gmail.com> writes:

> M-x 'org-mobile-push', with the latest org-mode leaves the files
> incompatible with MobileOrg Android application. There have been no changes
> in MobileOrg for over a year.
>
> I bisected the latest org-mobile related changes and noticed that reverting
> this one line below "fixes" the issue (at least for me). Since there aren't
> any tests, it's hard to validate changes and understand things easily.
>
> If anybody can point me in the right direction, I would love to look into
> it further.
>
> Cheers!
>
> diff --git a/lisp/org-mobile.el b/lisp/org-mobile.el
> index 6c7c8d0..7e1127c 100644
> --- a/lisp/org-mobile.el
> +++ b/lisp/org-mobile.el
> @@ -446,7 +446,7 @@ agenda view showing the flagged items."
>                                          x))
>                            (cdr entry)))
>         (insert "#+TODO: " (mapconcat 'identity kwds " ") "\n")
> -       (setq dwds (or (member "|" kwds) (last kwds))
> +       (setq dwds (member "|" kwds)
>               twds (org-delete-all dwds kwds)
>               todo-kwds (org-delete-all twds todo-kwds)
>               done-kwds (org-delete-all dwds done-kwds)))

IIRC this change was introduced to fix another bug. It might be useful
to discuss with the author of this change. Another option is to use

  (or (member "|" kwds) (cons "|" (last kwds)))


Regards,

-- 
Nicolas Goaziou