From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: A recent mobile org change causing sync issues Date: Sat, 24 Oct 2015 11:29:57 +0200 Message-ID: <87pp04y5pm.fsf@nicolasgoaziou.fr> References: <871tcr1hhp.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53865) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zpv7W-00008D-Lk for emacs-orgmode@gnu.org; Sat, 24 Oct 2015 05:28:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zpv7V-00045I-I6 for emacs-orgmode@gnu.org; Sat, 24 Oct 2015 05:28:14 -0400 Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:34657) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zpv7V-00044G-BJ for emacs-orgmode@gnu.org; Sat, 24 Oct 2015 05:28:13 -0400 In-Reply-To: (Steve Harman's message of "Mon, 19 Oct 2015 10:52:14 -0400") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Steve Harman Cc: emacs-orgmode@gnu.org --=-=-= Content-Type: text/plain Steve Harman writes: > Thanks Nicolas, > > I am not able to post the diff due to the personal nature of the data. > However, I can say that with the commit, the tags in the #+TAGS line is > missing. Also, a link to one of the org files is missing. Note that the commit alters neither TAGS lines nor links. > Would it be possible to revert this change? This change was introduced to fix a bug. Reverting it would break "org-mobile.el" in another way. The problem was reported but no one, so far, was able to investigate and tell what is wrong in the patch. > This is such a critical bug and it really disrupted many of ours > personal workflows. I sympathize. Unfortunately, it seems that no Org developer is actually using "org-mobile.el" or knows its internal. Apparently, mobileOrg expects a specific format for index.org, but it is not documented > It also embarrassed us towards our colleagues, > families, and friends who held the view that proprieatary solutions > are better. I wouldn't bother about people thinking that proprietary solutions are better. > In general, it is preferable to have a test suite which should pass before > releasing these commits. Yes, there is MELPA stable but not every package > is on MELPA. What do you want to test? We don't even know what output is expected. In any case, if you implement some tests, feel free to submit them to this ML. Meanwhile, would the following patch fix the issue? Regards, -- Nicolas Goaziou --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-org-mobile-Fix-c15db80e32d22dace184203f6f03a0b586bb4.patch >From 9a88fa0859075aae10a6cd90fb03d533acee1f6b Mon Sep 17 00:00:00 2001 From: Nicolas Goaziou Date: Sat, 24 Oct 2015 11:15:31 +0200 Subject: [PATCH] org-mobile: Fix c15db80e32d22dace184203f6f03a0b586bb4b50 * lisp/org-mobile.el (org-mobile-create-index-file): Fix c15db80e32d22dace184203f6f03a0b586bb4b50. --- lisp/org-mobile.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/org-mobile.el b/lisp/org-mobile.el index 6c7c8d0..17600bd 100644 --- a/lisp/org-mobile.el +++ b/lisp/org-mobile.el @@ -439,8 +439,8 @@ agenda view showing the flagged items." (if org-mobile-use-encryption org-mobile-encryption-tempfile target-file) - (insert "#+READONLY\n") (while (setq entry (pop def-todo)) + (insert "#+READONLY\n") (setq kwds (mapcar (lambda (x) (if (string-match "(" x) (substring x 0 (match-beginning 0)) x)) -- 2.6.1 --=-=-=--