From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH 2/2] org-capture.el: Support all target file specifiction
 variants in Customize
Date: Fri, 13 May 2016 18:11:46 +0200
Message-ID: <87posq7xa5.fsf@saiph.selenimh>
References: <87vb2k450b.fsf@quiz.hudson-it.ddns.net>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57040)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1b1Fgy-0002lF-FR
	for emacs-orgmode@gnu.org; Fri, 13 May 2016 12:11:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1b1Fgv-0000ls-UE
	for emacs-orgmode@gnu.org; Fri, 13 May 2016 12:11:55 -0400
Received: from relay3-d.mail.gandi.net ([2001:4b98:c:538::195]:41564)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1b1Fgv-0000lf-OB
	for emacs-orgmode@gnu.org; Fri, 13 May 2016 12:11:53 -0400
In-Reply-To: <87vb2k450b.fsf@quiz.hudson-it.ddns.net> (Phil Hudson's message
	of "Wed, 11 May 2016 23:13:56 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Phil Hudson <phil.hudson@iname.com>
Cc: emacs-orgmode@gnu.org

Hello,

Phil Hudson <phil.hudson@iname.com> writes:

> From 9ca987e6580ef633c961bf2023813d8544a0d36b Mon Sep 17 00:00:00 2001
> From: Phil Hudson <phil.hudson@iname.com>
> Date: Wed, 11 May 2016 22:49:01 +0100
> Subject: [PATCH 2/2] org-capture.el: Support all target file specifiction
>  variants in Customize

I cannot apply this patch. Could you rebase against maint and try
sending it again? Thank you.


>  				(const :format "" file)
> -				(file :tag "  File"))
> +				(choice :tag "  Filename"
> +					(file :tag "  Literal")
> +					(function :tag "  Function")
> +					(variable :tag "  Variable")
> +					(sexp :tag "  Form")))

I think you can remove all most of the redundancy using backquote, e.g.,

  (let ((file-sources '(choice :tag "  Filename"
                               (file :tag "  Literal")
                               (function :tag "  Function")
                               (variable :tag "  Variable")
                               (sexp :tag "  Form"))))
    `(repeat
      ...
      (choice :tag "Target location"
              (const :format "" file)
              ,file-sources)
      ...))


Regards,

-- 
Nicolas Goaziou