From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@gnu.org>
Subject: Re: [PATCH] Re: ob-clojure.el: Add ClojureScript interface
Date: Thu, 13 Feb 2020 17:04:23 +0100
Message-ID: <87pnei8oe0.fsf@bzg.fr>
References: <20180422205003.87836-1-roberthambrock@gmail.com>
 <20180422205003.87836-3-roberthambrock@gmail.com>
 <87v9ocuesg.fsf@gmail.com> <87imkb7mwj.fsf@gnu.org>
 <87y2t6fqwj.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:49913)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <bzg@gnu.org>) id 1j2GyY-0003kY-QP
 for emacs-orgmode@gnu.org; Thu, 13 Feb 2020 11:04:28 -0500
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org
Sender: "Emacs-orgmode"
 <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
To: stardiviner <numbchild@gmail.com>
Cc: roberthambrock@gmail.com, emacs-orgmode@gnu.org

Hi,

stardiviner <numbchild@gmail.com> writes:

> And patches in attachments.

Applied, thanks.

I made some minor modifications:

- I added the TINYCHANGE cookie in both messages
- I replaced "ob-clojure.el: (...)" by "ob-clojure.el (...):"

In general, try `C-x 4 a' on a change, either from magit or from
the modified buffer: this will format a correct changelog entry.

Also, users may need to figure out that ClojureScript src blocks
need a proper environment to execute src blocks.  I.e. we should
recommend users to have their .org file within a ClojureScript
project -- I added something along these lines in the ORG-NEWS
entry.

If you want to contribute further, you'd need to sign the FSF
papers: https://orgmode.org/request-assign-future.txt

Thanks!

-- 
 Bastien