From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>
Received: from mp10.migadu.com ([2001:41d0:2:4a6f::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms5.migadu.com with LMTPS
	id uI45IM/702LDUAEAbAwnHQ
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Sun, 17 Jul 2022 14:08:47 +0200
Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp10.migadu.com with LMTPS
	id yGbkHs/702IAZQAAG6o9tA
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Sun, 17 Jul 2022 14:08:47 +0200
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id 1A090113A2
	for <larch@yhetil.org>; Sun, 17 Jul 2022 14:08:47 +0200 (CEST)
Received: from localhost ([::1]:44592 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	id 1oD34n-0007lE-S7
	for larch@yhetil.org; Sun, 17 Jul 2022 08:08:45 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:53230)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <yantar92@gmail.com>)
 id 1oD34F-0007l5-66
 for emacs-orgmode@gnu.org; Sun, 17 Jul 2022 08:08:11 -0400
Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]:40734)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <yantar92@gmail.com>)
 id 1oD34D-0000aP-Jv
 for emacs-orgmode@gnu.org; Sun, 17 Jul 2022 08:08:10 -0400
Received: by mail-pl1-x635.google.com with SMTP id b2so6823680plx.7
 for <emacs-orgmode@gnu.org>; Sun, 17 Jul 2022 05:08:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=from:to:cc:subject:in-reply-to:references:date:message-id
 :mime-version; bh=NVuXslU3w/AuvdR6H8bqapKDdhzHZGYds6vFA7AhsEc=;
 b=POcAZryXyKWI+7lrj2ZvY2lg+biSd/tXH5nep2hWL4BODzLRdKiKGcXP/xa25ZFd2e
 NS5Qp0uvA6fJLcs9k9G5efSHYgtEutadq0OyLxwn16BLeRKyAiCi0Zx3JJ1nApCFkwFD
 JXJUeNDtWnIlJaKMiF6siq5qhL1KgxGT59edaCSb+hLgK/aqeyPTgPFV/jAqn15OlmjN
 aZWmjGfILbw5XH6Dfh1fNXEPc+BoGqB62fLOWeH52PSORf07/aB+gU84m2Z6Va3nt3Tj
 SoOhBD5YluilzLarBzQX6Ro1o98kkJtcgogRdqoXwywdXtCzFQW+y6pm8tefJH8gPa/6
 Tk6Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date
 :message-id:mime-version;
 bh=NVuXslU3w/AuvdR6H8bqapKDdhzHZGYds6vFA7AhsEc=;
 b=JBWGvGbPJ7l1GnD1fHWZuC1Go6zmJxhSDaAW6whe6AxaqrGV55iu0Hn25jvjwZTFv3
 sJqUKZvaIVFQjeuhWGUbCIUJ4XVod/WeYbwiSp1AQuGGQ/7r1epwVur2/j3sw/SPNuYh
 pt2Cj4ux/H3SYkjrKZz++lIQV7dhOf35bD7YxDPV8HkFqliv9DbD7QTGVDlCsYghar1X
 8ZnCi3AszBTuTtmgDMGe2/upB/54Nu1QgmhHREIz5t3QKQbnXLb/B34+es7BuiphcnLg
 qSXQ4vkjpGuHiXcwwBAvakoW+k7kiI3MlgETv+Nohkg9mW45pdOJK0dF05ydElvTHtgW
 +Vjw==
X-Gm-Message-State: AJIora/oaH/iVn+AhNvykC4sKFEuI8nQiJaLgD9SxTe+K1opiU5REXQ7
 SuMXWbv4KZbgIMPBxlmN8PQ=
X-Google-Smtp-Source: AGRyM1uoX4ayFSaqQ8vlpJ8Qg6VblyKgCnGMxgr/Ixxfx/YlNFnYLnWOGz5kRpzA0fEzg1oN3gyWjQ==
X-Received: by 2002:a17:902:d683:b0:16c:b718:f94b with SMTP id
 v3-20020a170902d68300b0016cb718f94bmr15996259ply.9.1658059688161; 
 Sun, 17 Jul 2022 05:08:08 -0700 (PDT)
Received: from localhost ([2409:8a70:2bd:4d0:8ec6:81ff:fe70:339d])
 by smtp.gmail.com with ESMTPSA id
 a28-20020aa795bc000000b00528c8ed356dsm7419944pfk.96.2022.07.17.05.08.06
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 17 Jul 2022 05:08:07 -0700 (PDT)
From: Ihor Radchenko <yantar92@gmail.com>
To: Visuwesh <visuweshm@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Re: [BUG] org-agenda-remove-restriction-lock does not
 remove file lock [9.5.2 (release_9.5.2-17-gea6b74 @
 /nix/store/iqqk7iqfwmfc6r78xg2knyq7hww2mhs4-emacs-git-20220225.0/share/emacs/29.0.50/lisp/org/)]
In-Reply-To: <87ee2pythp.fsf@localhost>
References: <87v8w2qdgp.fsf@gmail.com> <87ee2pythp.fsf@localhost>
Date: Sun, 17 Jul 2022 20:09:10 +0800
Message-ID: <87pmi46ivt.fsf@localhost>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=2607:f8b0:4864:20::635;
 envelope-from=yantar92@gmail.com; helo=mail-pl1-x635.google.com
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: emacs-orgmode@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org
Sender: "Emacs-orgmode" <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>
X-Migadu-Flow: FLOW_IN
X-Migadu-To: larch@yhetil.org
X-Migadu-Country: US
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org;
	s=key1; t=1658059727;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:in-reply-to:in-reply-to:
	 references:references:list-id:list-help:list-unsubscribe:
	 list-subscribe:list-post:dkim-signature;
	bh=NVuXslU3w/AuvdR6H8bqapKDdhzHZGYds6vFA7AhsEc=;
	b=CrwSk7WszW8K7VmYYUZS+oJVxTeEj3VIovKe8dYkbsGxCajPA67psVVWctfPi4Ps5msZR1
	usfj2WZENpxkMHLK2nrA6KMSlO3LrnaT6THHkD4r8izoPKGVAoBuzodiWVba/QsA5fXLXV
	bq4aiyy4Ml1sI1Sk5b9FqFQRZn7bTpQUxaDS23Ftv2lP41okcsPW9dSyR+8b58vgCtwj3T
	1G39XUsB9GIZlasB1lwcc2POob2XAPN7rQRmqY9Qc54e9rbbsFTEz+bhcwj2/x+4h41POG
	h2vsRpxf7XJaLXh3NHiCx5RanadySFc49FLuEv8mDLJ+xx83Qv+UzFCp9oq17w==
ARC-Seal: i=1; s=key1; d=yhetil.org; t=1658059727; a=rsa-sha256; cv=none;
	b=Vjq0cfZG4p2VgzdKFhrdOuK51nWtJGidG6MEX7L7OTMBjIx5ykfQ+9LTJ7iBumHrv7eLCm
	r32eiP85ZBjr3YGV8e+u1tceJvFCwAa8fFU9dOFvIB4cUKv/1jM85b4mjjoYmEqPaLZ1U7
	JKZH7le/OBfLD3lPAWHQUbUVOmekyHIownVMVsvHFV4Q3BVTV7hxCltsV8/Y3rb5dRqIf5
	zTNOKa50WrWfe1aH+FcCgwS///UKvVPPUFHxUaj6nvQX2gpWZFLGcx2OGSu3i9UcsvcRtr
	ZqPNVSKDyWmHXJpo2IO0Rl97lx8qx2XD70O+65M7AmHU8yMXL1RVY+Chnb3d3A==
ARC-Authentication-Results: i=1;
	aspmx1.migadu.com;
	dkim=pass header.d=gmail.com header.s=20210112 header.b=POcAZryX;
	dmarc=pass (policy=none) header.from=gmail.com;
	spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"
X-Migadu-Spam-Score: -5.36
Authentication-Results: aspmx1.migadu.com;
	dkim=pass header.d=gmail.com header.s=20210112 header.b=POcAZryX;
	dmarc=pass (policy=none) header.from=gmail.com;
	spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"
X-Migadu-Queue-Id: 1A090113A2
X-Spam-Score: -5.36
X-Migadu-Scanner: scn0.migadu.com
X-TUID: psdubAHiehrO

Ihor Radchenko <yantar92@gmail.com> writes:

> Visuwesh <visuweshm@gmail.com> writes:
>
>> C-u C-c C-x < followed by C-c C-x > does not remove the file restriction
>> lock.  
>>
>> `org-agenda-remove-restriction-lock' checks for non-nil value of
>> `org-agenda-restriction' but `org-agenda-set-restriction-lock' explicitly
>> sets it to nil when TYPE is 'file.  Setting `org-agenda-restriction' to
>> a dummy value like 'dummy gets the job done.
>
> Confirmed.
>
> The fix is attached.
> Setting org-agenda-restriction to non-nil appears to be risky since
> org-agenda-set-restriction-lock explicitly sets it to nil. So, I use
> different approach.

Fixed.
Applied onto main via df0e96ba4.

Best,
Ihor