From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id X4esLOGpwmMxmAAAbAwnHQ (envelope-from ) for ; Sat, 14 Jan 2023 14:10:57 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id AKHsK+GpwmOeGAAA9RJhRA (envelope-from ) for ; Sat, 14 Jan 2023 14:10:57 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5129E17575 for ; Sat, 14 Jan 2023 14:10:57 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pGgIP-0007gx-Dv; Sat, 14 Jan 2023 08:10:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGgIN-0007gc-TX for emacs-orgmode@gnu.org; Sat, 14 Jan 2023 08:10:04 -0500 Received: from mail-yqbcan01on20718.outbound.protection.outlook.com ([2a01:111:f403:7052::718] helo=CAN01-YQB-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGgIK-0000YJ-JM for emacs-orgmode@gnu.org; Sat, 14 Jan 2023 08:10:03 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cYC2u93h0jZxIas5ThYZZzJrIbKeZ7LzYxV/6/0ehQAHkWhXj9B0p+tZkS6oO4DhETGgIEvVlZ4oNE2WrvD5IzNEJjPJUKVi8Cqzoz23E4RM65UoKIq0VsF4YSvYQppI+i0ByH5VCJMLNrV4WeCFgxu9PmHahOXB/71FB+0nKi43YkwTfxgm5WbrUuttrKZamJeiZVsf7TGJNiTP0PK5EzGG+OOn1q7Rb3OGodlTQrAsCBKCI8JyA/5Ryx2jx14MEZ7mrZaN9eWrXV/L5RXWiFOe7kGPodljN8EsTaWCHcBHgOUz9tyJ956HFEMc/fKZejwW0DX4ctR8qxfi9M4sXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PopY+p9DU6AmKnrACViMyr2Yyn2KGAMxeeXIUNSHnEw=; b=gMaTDNNlTnKj+cnox7T10GsO5/eKf4oje5NWTR0EbLxvEtg7KkdfDhtylkNur3JobCxA5oK6zIF3w40nLGh2nYv2ZyuTyBNlR8Ob5oHYgtRdAowR1uMuaWk5lUJRKQiYyTiNGshsLmHtuHQXGSAp0RiDy5dJuRtgkO7qzbUlLBLTFmBXeFBOriIWDz9smCxTCrRryptiHIVHyyE9hV18fapDj5owErecDOYfgT5UH1xPckE+P/w2ue4pzNAbo/2/PLAtw8b2Q0kUA8oRLF2v+lKjSFBdOu8PJzMrveYXD6idSdG2wQJ4tAzJYlDwpzo7ePNNf5jZSgQpj+QxZs21Bw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=umanitoba.ca; dmarc=pass action=none header.from=umanitoba.ca; dkim=pass header.d=umanitoba.ca; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umanitoba.onmicrosoft.com; s=selector2-umanitoba-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PopY+p9DU6AmKnrACViMyr2Yyn2KGAMxeeXIUNSHnEw=; b=RWxBw32g4QnOAlzSkwH0rPRIsMaQMy1+rzRxrLkVU4JcKosw0rM8sZ1/+96Ji5grgcCTN6nsNhDGD+VXZq1aDlfZ3D2vrPPMKqpv2Kg4mFwZ80mueUxbfdEikG3gyVyBA5qZ4WCUWTcrukEbddmvBoVdg6t94Q0OwJ1Y8aQ2qwE= Received: from YT2PR01MB9953.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:db::17) by YT4PR01MB10712.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:101::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.23; Sat, 14 Jan 2023 13:04:56 +0000 Received: from YT2PR01MB9953.CANPRD01.PROD.OUTLOOK.COM ([fe80::48fc:eb89:9250:b0e7]) by YT2PR01MB9953.CANPRD01.PROD.OUTLOOK.COM ([fe80::48fc:eb89:9250:b0e7%3]) with mapi id 15.20.6002.013; Sat, 14 Jan 2023 13:04:56 +0000 From: Leo Butler To: Ihor Radchenko CC: Org Mode Mailing List Subject: Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects Thread-Topic: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects Thread-Index: AQHY8srL9HYY78NwOki4MB+cHbDIhw== Date: Sat, 14 Jan 2023 13:04:55 +0000 Message-ID: <87pmbhi7wp.fsf@t14.reltub.ca> References: <87mt92elyy.fsf@t14.reltub.ca> <87mt9128sz.fsf@localhost> <87zgd1b4rn.fsf_-_@t14.reltub.ca> <8735asbtfe.fsf@localhost> <87pmdvamwf.fsf@t14.reltub.ca> <87bkpaguy3.fsf@localhost> <87leocuhpg.fsf@t14.reltub.ca> <87359esah2.fsf@localhost> <87cz8ifioa.fsf@localhost> <87sfh9vukl.fsf@localhost> <87fsd7wolt.fsf@t14.reltub.ca> <87r0wk29dz.fsf@localhost> <87358ywn5g.fsf@localhost> <87bknh5nva.fsf@localhost> <87358ovj53.fsf@t14.reltub.ca> <87a62vitpu.fsf@localhost> <87lemfqbwl.fsf@t14.reltub.ca> <87o7r6m8sf.fsf@t14.reltub.ca> <87fschfhke.fsf@localhost> <87mt6m5n6u.fsf@localhost> In-Reply-To: <87mt6m5n6u.fsf@localhost> (Ihor Radchenko's message of "Fri, 13 Jan 2023 18:00:57 +0000") Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) x-ms-publictraffictype: Email x-ms-traffictypediagnostic: YT2PR01MB9953:EE_|YT4PR01MB10712:EE_ x-ms-office365-filtering-correlation-id: e82950b3-84e0-41d7-ec4e-08daf62fef0d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: i9sR7r3LqhaJRqviF/uUP/e+w7rbj7E0Ftnv6NT2wTd+D1/pOL/4ORWIXywNmSSMGjDjoK7ZjOgQQ1FXrD9Uesv1oegTxhypq2A00rNotq5MwL8q64K4IwYyFYtrmMoPjtbxBHPBst+eKxDwbHvHMslnk+G3bgRfuH52ZMLQ+xqwXLGCRKSmTmeGpEqnwatCezPORHbCNQihERthxtQhbhyHhwtTO3FhqDQ766DKW8dohrSWpmt4w+HpqFPWItVIg8kqnA/zq5LSPo5fLkLohH4mEOTS87HGxc0l+aGU9tBomeJiVOKe0JBwq0ylW0RsA/wyfgk3PgoU/RnLFVI0xcW9VE8b/WIVOABYsfouJMiBaU4o0z88vDAOqZJQ9prwAz/gR0LMafnksqHG9ftnK7lsNQrXWaA1cTY6PCfs16qQ+0H9a1LzAktBMG/3InLfAZRHpggOHKFTW2kHZkNaoD6cRZ8SNcInAn021DksbEvmxy7kJ5y9Pz4gOzJQ5vTPZaeUqsfz+U1Bw7hVkiXvAVkIa5fE3UqnOLqwGonvVZk+5RqdkcdpeLGbq20d9DNNVLnO/YRe9mvsrL5/Hja3Adui+6ICj2whdvoTTGu36om8SffpDCigya90mHHxh2HkxvcNNOrQvwAlNZu4PlukL95MHNpDNTDp1FNPNlFBQL/C0BId1GI6O9vTiRqj6NEVZg8zzePpdhS9pbh7S2kjBw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YT2PR01MB9953.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230022)(376002)(136003)(396003)(39860400002)(366004)(346002)(451199015)(71200400001)(8676002)(6916009)(4326008)(66476007)(64756008)(9686003)(6512007)(186003)(786003)(316002)(66556008)(66446008)(91956017)(66946007)(76116006)(26005)(478600001)(41300700001)(8936002)(5660300002)(83380400001)(2906002)(122000001)(6506007)(38070700005)(38100700002)(86362001)(41320700001)(6486002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?fGYr14jxE3+13SHGY1GvaqgsOb/g4EJOgQhCLmbbHEjsweeRj7VY2VhVSU?= =?iso-8859-1?Q?CXsIoSxZXaa1aEfic1XmjmiIFR9BBZXjq+S/wWJc6DO6UVXuGgTn7FbwoC?= =?iso-8859-1?Q?8e4lGwQU5OB4US/wwk3tg1JVNtQEwXQQuxI+cJG2GD4BM+PozjtzgN1w+x?= =?iso-8859-1?Q?iNHDvPnHymmsIbpq3i/4yOunuNxdvAgW+jLetTsbGzzEmU3Sx1p6kkF6dQ?= =?iso-8859-1?Q?eTI+i75Vm5NtGu9gTUu/5uKYR5nUjgp6IIOs8GT6Os5+dfRRHkJNoskFSo?= =?iso-8859-1?Q?ZJZXGp+hFVZGsjjuhkYtSQDJ0w2zy3IOH4xyruDJIPQ7TWUBw8PPVP+ty5?= =?iso-8859-1?Q?0htBrWNo51kYFfqNFyU3ErE6SWXnyIqvjKyBFoIVLhkieRBuPfE7VyRJyi?= =?iso-8859-1?Q?oLDFg7bkDKsve3h5TkO+lmx+RBxwzWIkVhFCu3sx7wmlS0n0GzI12RcZkh?= =?iso-8859-1?Q?44RSVWT2fS2CBzMfaQj5EEbBmgCCH8IbrSy4Ar7m3Ek/yJje7p8QfgSDqF?= =?iso-8859-1?Q?vLLxTywckbujoNxPpCYahYmOYW5mXILZyC1pXUbUDt2vWG+hz9Zpd9fCBC?= =?iso-8859-1?Q?+9BQW5wExPybt4Zp5qZRKnq8WTMuoYitPlmY0UNjAK6xKOSL2FmSj5mhAs?= =?iso-8859-1?Q?f7cS2XFXfPy7RhJwuc1L0tMml6gLLBAV5cvz4d74i4Oi12+tP5cerx4sZZ?= =?iso-8859-1?Q?sxedTVmKgLiDmZ3qEKWAwe0r+Mb1707a5ssV4VBwde3D6fRJR5YHapx7ZD?= =?iso-8859-1?Q?d3ILGkhnjQhS3280seEly+r0JkvmrKOu3LZEklvHLgY7lsYWY8RZzdaBll?= =?iso-8859-1?Q?BmynRDpAuW4i6Bmaa4wM3RxyTsp9vjxOA+XMPT3dO4a42eV9hIdzvYVgXg?= =?iso-8859-1?Q?8z4Grvh7cWRNffuEBpBo2Hzm6i4cPu7/M6sO+tZ96+IqSgVN1Nw1R4klCD?= =?iso-8859-1?Q?y2erh3LzQ3vuPcS0KO0UiNXOz3BaHdkkHBt1A7/XIIgL1cXpGQd/KHQgCr?= =?iso-8859-1?Q?FkiIxWXKDzxV3J1cXQZPW49j2q5iUMxAUlWa/K07WbPn+0vMsFvUryhfVP?= =?iso-8859-1?Q?xcC11k9poPQ5GZi5MDO7FVb9PnPGiRn+aEo6vWaiiZKrnuKXHlQrRpU+O6?= =?iso-8859-1?Q?3lEFblxhqAJfxIDAYOegpPPJ/Z31FTWzFbEqJSyvGePOIu7rDlbrKH4tF9?= =?iso-8859-1?Q?2Vnq5eUbWohvQEPBdb4p3kylPl6bw4lMEKHTgmxJyXBZOM2orcnkVom5od?= =?iso-8859-1?Q?dqpo+yG9uA4wWf1O8YcNLkxzUtLZB6hc+UMT7bzsjU3VVVHt34oBmcqNgq?= =?iso-8859-1?Q?/v/jb5mv/UJcAnkqpK4xGKZ4MWn8mc00wZfZJMT+MVB8ZRDzcKAmAbXzKP?= =?iso-8859-1?Q?ql0FrgEUqNPtcZzkmF6RHyyA4H7leEi4DY/tKKiY7pbHPVZg4vVCOJm+Xa?= =?iso-8859-1?Q?lZmbGuqus0mrgGvFNZx0kVTK1r2qqHfmmdlCOG8yQjWlSRVHBrMNz0Gadq?= =?iso-8859-1?Q?xtdwp3HHiJlS1B1qNKyTMrDqHhDGqpEib4Z85OS1y6C4uObThr/kJ1JrsY?= =?iso-8859-1?Q?iui6Fo7S5AIrLoj90OYN80T1SAy4Bjy/6LwS9mClsL93Dck3SkiutnqyER?= =?iso-8859-1?Q?3AKQszvoHA8/65EXiw32CI+/oWem2HATx77Ks9574vr+6Nk2V9dYOpSw?= =?iso-8859-1?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: umanitoba.ca X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: YT2PR01MB9953.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: e82950b3-84e0-41d7-ec4e-08daf62fef0d X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jan 2023 13:04:56.0284 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4f80dd0b-338c-4e4c-8a14-90446962f7b8 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mFL9O5whf3rbI7+SJqu0DRbovaDzxaxJeHKqLGLa9rUbo14XRst00A4qKxKV8G2NLiI9Nqmb4v4L7CDi276lOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT4PR01MB10712 Received-SPF: pass client-ip=2a01:111:f403:7052::718; envelope-from=Leo.Butler@umanitoba.ca; helo=CAN01-YQB-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=pass header.d=umanitoba.onmicrosoft.com header.s=selector2-umanitoba-onmicrosoft-com header.b=RWxBw32g; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=key1; d=yhetil.org; t=1673701857; a=rsa-sha256; cv=pass; b=UZnCwlfPWjoZKnHrpSUGQ8MoRoqI7MW9OFmK0zc16bCwoMUgoSiM0LhTdXIY5W01q+jOnN jpHdczu4gXP06P7ceqp5ZQzSj9cwE9kuF9G0hsurNFN79fAgxDoe0GP1siRZNWXNqkZIjC Bs9854dqPEK7ebRAqcFl2Tj2hnYBRsxwTkjNlAvzoQEm4bz1QvC9jCtJpodXU2FEEbz3OJ PJjaH2Zk0Nje/uk7t4QxdnLvKIZrElpvgrAhwLJB2MXVtPUxuuGTMrP/zEBsxxWwdERLq9 H8oVd9SqqDmGYQhivECN8S8Qik8BmmPjj9/eyQXqU/VInmCa8gkY/GmMoy4vmA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1673701857; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=PopY+p9DU6AmKnrACViMyr2Yyn2KGAMxeeXIUNSHnEw=; b=Yg50Ym4xs59/E+1Qo5TTciwhLs/MzWMrU0g2ertkIOfsmwQ9VJNKZ84l7P63hD5er93cWj zd1xO4Uq0b0L3sIX2MEzontNdSHaSczm68oCafXTNrJYmk5dV5Bqo/WS9Hto9bdX4wm5i3 wyEDWdWW5MzXv1zcdng5o1JykjGWQUGr4T+ku96rHT1sNGo7DnzIhTx0jx8bSHO4nk5rWn CsrnxDdRBXZcg5GScANjhl93aZIGP86K5aAD+QD9Pg8vP3Cg063XsqvIzkS13n0pwpafLk NiciVDK19l9pDZlxefxXTxGY1RcGz9PUiup0ROUpP/LjLoHRxnwyewvQBR/bzQ== X-Migadu-Queue-Id: 5129E17575 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=umanitoba.onmicrosoft.com header.s=selector2-umanitoba-onmicrosoft-com header.b=RWxBw32g; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none; arc=pass ("microsoft.com:s=arcselector9901:i=1") X-Migadu-Spam-Score: -8.13 X-Spam-Score: -8.13 X-TUID: /svn4Z4STM8y On Fri, Jan 13 2023, Ihor Radchenko wrote: > Ihor Radchenko writes: > >> So, the test failure is real. > > The error buffer contents when the test fails is the following: > > warning: using the gnuplot graphics toolkit is discouraged > > The gnuplot graphics toolkit is not actively maintained and has a number > of limitations that are unlikely to be fixed. Communication with gnuplot > uses a one-directional pipe and limited information is passed back to the > Octave interpreter so most changes made interactively in the plot window > will not be reflected in the graphics properties managed by Octave. For > example, if the plot window is closed with a mouse click, Octave will not > be notified and will not update its internal list of open figure windows. > The qt toolkit is recommended instead. This is not being caused by a faulty test. The default graphics toolkit for octave is not gnuplot. To get that warning, the graphics toolkit needs to be set to gnuplot. But, that is not done in those tests, so where/how is that happening? > line 0: warning: iconv failed to convert degree sign This warning makes no sense to me. > error: ignoring const execution_exception& while preparing to exit > [ Babel evaluation exited with code 0 ] > > Exit code is 0, so octave does finish. > > Hence, test assertion that > (should-not (buffer-live-p (get-buffer "*Org-Babel Error Output*"))) > does not appear to be accurate. I guess it depends on what is meant by `accurate'. Those warnings make me think that the test is running in a mis-configured environment. > > Leo, should we simply remove the assertion? Ok. I would really like to understand why the two tests are failing on sourcehut (but not the one that creates a session), but I can understand your viewpoint. Leo=