From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 8DgZDtECuWUQcAAAe85BDQ:P1 (envelope-from ) for ; Tue, 30 Jan 2024 15:08:17 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 8DgZDtECuWUQcAAAe85BDQ (envelope-from ) for ; Tue, 30 Jan 2024 15:08:17 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=CAfQ1x1I; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1706623697; a=rsa-sha256; cv=none; b=DoYvoLvUDed+w/CYWAAo8IMcWUTsjN147OxbTvbJ4LrAT6OjO29WIMY+xu354G0lrAsCtm Sv46M3/Wl4thfvZ4NlYzJWRVnkyYY0+S2+D7E8jN8llvq9enYHLggDWCZMSf42N5+z2C04 C3ZNeKhV3Kv5rsVeDJfwj0tP/zmp2KsWdzPNLvIO2srRm2fS3vQH9dDeQHue7xcbQDQ52f +yV0gU64E4VXsED1qRAbl7cYjEvz3nRqjKnZknsZn92KnGBvOx1iCSi3HjZswzCQBYmfD1 bq3kaqHCfYTaDAiaOqWpzHI82fW/xDVEp7gAgQkl7S59YrOyW8m/BkwQzFWsFA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=CAfQ1x1I; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1706623697; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=02irJhx12mYQ4ag2k6F6dSnKW0w0EYzDoCZV9lz2+Mw=; b=DHonEneOmkGMnAwT7/dWqGYoB+L9s4CivnSK3GaF0yVe2tQWWfcYPr99aqs037cpHj97TH kpLQQBkOK3sZ9m2UA5C4iRKvWXFKJ85n8ytqLOkQI8VRkU7h+cX8JwStkV//94ixtkFYSx +bcqQobKL0ubtY491bknDFkpsluQ3c+u8DUjXIGEWL3i6hCqnXwnTuT2Z9j4qszbrWXZ0u WnIbsN4zLg14DitRzDnVmJfD3srKHEcs8GHJTusWBOSMW4UU+OPQ0nds5k3vEKoJPquETb TJfMJZjZXCCShDiI2BUHrTuC8htqXCmwWLOZBk/RGfhlcjICWpbl/ZBPMsGfCA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 29FCC2062C for ; Tue, 30 Jan 2024 15:08:16 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rUolg-0002bH-1t; Tue, 30 Jan 2024 09:07:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUole-0002b9-Hg for emacs-orgmode@gnu.org; Tue, 30 Jan 2024 09:07:14 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUolW-0005Tm-U7 for emacs-orgmode@gnu.org; Tue, 30 Jan 2024 09:07:14 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 8D312240027 for ; Tue, 30 Jan 2024 15:07:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1706623624; bh=P7DTYXUGydmZwVNrhKxBv3MTaic8oARGPNRx8HDrURI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=CAfQ1x1I0UvNUidVmtfyj51Xic+VcKHmXWGr+AbAJcupaQGX1335AN7ESw7cbrAvn 6ZGMtVNMGchrsrgl3F0rKYU2BLJZNPEkWXl6Mu8S7uVoAH5vL0StD5O0iEEkx4vuyz WM9ej4Jeqfa+VLUH/8XO3MN9ab5QIxwb2voS70ZQZtFuvf2g/EIGEvSe4nj0SgIWWd kcnn4rcmRuo/iUQCcIfnhCXvLbtgI/kez+hbzv3Q8noWyhhThMMQbnyOjCWNRhBw6X Swfc5+48ZVMdxFCWoi5ua/A56JXH/W0Ch8/6W/Us1mW1RP0Z7Y6Mo9jrjtE2QBjJGG 7HHi2o4Nssz+w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TPRn345xvz6tsf; Tue, 30 Jan 2024 15:07:03 +0100 (CET) From: Ihor Radchenko To: Tennyson Bardwell Cc: emacs-orgmode@gnu.org Subject: Re: org-store-link modifies readonly-buffer In-Reply-To: References: Date: Tue, 30 Jan 2024 14:10:35 +0000 Message-ID: <87plxivrms.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx10.migadu.com X-Spam-Score: -7.99 X-Migadu-Queue-Id: 29FCC2062C X-Migadu-Spam-Score: -7.99 X-TUID: WzDIEtICDB+e Tennyson Bardwell writes: > It seems as though =org-store-link= does not respect the "readonly" part of > read-only buffers. I noticed it myself[1], found a bug report on > stackexchange[2], and did not see the appropriate check in the code[3]. > > If this is unintended, I would be happy to try to submit a PR. I have not > yet contributed to any emacs ecosystem, so I would be slow & bad at this, > but happy to try. Confirmed. This is intended, with the main purpose of not barfing with error when users call `org-store-link' in read-only *Org goto* indirect buffers. More generally, Org mode handling of read-only state is rather inconsistent. We have a number of places that do ignore read-only and a number of places that don't. I do believe that the right things to do is respecting read-only state with an exception to *Org goto* buffers (or maybe other buffers that we should explicitly mark). But doing so might break user workflows. We need to carefully study various instances where Org mode ignores read-only state to decide what is the best course of action. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at