From: Ihor Radchenko <yantar92@posteo.net>
To: Morgan Smith <morgan.j.smith@outlook.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Testing: Add tests for `org-tags-sort-function'
Date: Tue, 24 Dec 2024 12:25:46 +0000 [thread overview]
Message-ID: <87pllhgtdh.fsf@localhost> (raw)
In-Reply-To: <CH3PR84MB3424D8D8059255B092C2EAA2C53E2@CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM>
Morgan Smith <morgan.j.smith@outlook.com> writes:
> I've polished the patch slightly but it's almost identical to what I
> submitted before. There is one remaining issue as you can see above but
> I'm trying my best to ignore it. I believe this patch can be applied
> before the issue is fixed. I would like this patch to be accepted so I
> can build off of it to submit another patch that includes an alternative
> function to set `org-tags-sort-function' to.
It took longer than necessary, but I now applied the patch, after fixing
the docstring in `org-tags-sort-function'.
Applied, onto main, after removing the FIXME comment.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=4e8cf7df11
The docfix:
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=1abdfafe25
--
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
prev parent reply other threads:[~2024-12-24 12:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-15 15:27 [PATCH] Testing: Add tests for `org-tags-sort-function' Morgan Smith
2024-09-01 13:33 ` Ihor Radchenko
2024-09-02 18:36 ` Morgan Smith
[not found] ` <875xrdzyvs.fsf@outlook.com>
2024-12-11 0:05 ` Morgan Smith
2024-12-24 12:25 ` Ihor Radchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pllhgtdh.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=morgan.j.smith@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).