From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Schulte <schulte.eric@gmail.com>
Subject: Re: [PATCH] Fix some #+ blocks fontification when there is no	lang
 attribute
Date: Fri, 01 Jul 2011 17:38:16 -0700
Message-ID: <87oc1decuf.fsf@gmail.com>
References: <loom.20110701T164603-332@post.gmane.org> <87oc1e58ak.fsf@gnu.org>
	<loom.20110702T020009-500@post.gmane.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([140.186.70.92]:57408)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <schulte.eric@gmail.com>) id 1QcoE4-0004tK-RR
	for emacs-orgmode@gnu.org; Fri, 01 Jul 2011 20:38:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <schulte.eric@gmail.com>) id 1QcoE2-0005Aq-I2
	for emacs-orgmode@gnu.org; Fri, 01 Jul 2011 20:38:24 -0400
Received: from mail-pv0-f169.google.com ([74.125.83.169]:63472)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <schulte.eric@gmail.com>) id 1QcoE2-0005Am-7S
	for emacs-orgmode@gnu.org; Fri, 01 Jul 2011 20:38:22 -0400
Received: by pvc12 with SMTP id 12so3943649pvc.0
	for <emacs-orgmode@gnu.org>; Fri, 01 Jul 2011 17:38:21 -0700 (PDT)
In-Reply-To: <loom.20110702T020009-500@post.gmane.org> (Julien Barnier's
	message of "Sat, 2 Jul 2011 00:03:22 +0000 (UTC)")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: </archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Julien Barnier <julien@nozav.org>
Cc: emacs-orgmode@gnu.org

Julien Barnier <julien@nozav.org> writes:

> Hi Bastien,
>
> Bastien <bzg <at> altern.org> writes:
>
>> > * lisp/org.el (org-fontify-meta-lines-and-blocks-1): Fix test for src blocks
>> > lang attribute
>> >
>> > When there is no lang attribute to a block (for quote, verse or others), the
>> > lang variable is not nil, but an empty string.
>> 
>> Applied, thanks!
>
> Maybe I'm mistaken, but I think there is a problem with the patch : in the patch
> file I sent the new line was the following :
>
> ((and lang (not (string= lang "")) org-src-fontify-natively)
>
> But it seems that the applied patch in the git repository is the following :
>
> ((and lang (not (string= lang "") org-src-fontify-natively))
>
> http://repo.or.cz/w/org-mode.git/commitdiff/549a5212566e300023e038ec945cb9e8efe37e19
>
> As you can see, the parenthesis is not at the right place, and this seems to
> break completely src code blocks fontification...
>
> Thanks in advance,
>

Fixed.  Thanks for reporting -- Eric

-- 
Eric Schulte
http://cs.unm.edu/~eschulte/