emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Subhan Michael Tindall <SubhanT@familycareinc.org>
Cc: Charles Millar <millarc@verizon.net>,
	"emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>,
	Kaushal <kaushal.modi@gmail.com>
Subject: Re: [feature request] org-capture-window-setup to stop capture window taking up whole frame
Date: Tue, 23 Jun 2015 22:31:59 +0200	[thread overview]
Message-ID: <87oak6rwsg.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87a8vxcut6.fsf@delle7240.chemeng.ucl.ac.uk> (Eric S. Fraga's message of "Thu, 18 Jun 2015 08:57:57 +0100")

Hello,

Eric S Fraga <e.fraga@ucl.ac.uk> writes:

> Thanks for this.  Works okay if there is more than one window which is a
> step in the right direction.  In any case, you've pointed me in the
> right direction and the following seems to work fine (with very limited
> testing):
>
> diff --git a/lisp/org-capture.el b/lisp/org-capture.el
> index eeb05ca..ac0ed6f 100644
> --- a/lisp/org-capture.el
> +++ b/lisp/org-capture.el
> @@ -1590,8 +1590,7 @@ The template may still contain \"%?\" for cursor positioning."
>      (unless template (setq template "") (message "No template") (ding)
>  	    (sit-for 1))
>      (save-window-excursion
> -      (delete-other-windows)
> -      (org-pop-to-buffer-same-window (get-buffer-create "*Capture*"))
> +      (org-switch-to-buffer-other-window (get-buffer-create "*Capture*"))
>        (erase-buffer)
>        (insert template)
>        (goto-char (point-min))
>
> Feedback from real emacs lisp people welcome...

It looks good. Could you turn it into a proper patch with a commit
message? 

Thank you.

Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2015-06-23 20:30 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-08 15:23 [feature request] org-capture-window-setup to stop capture window taking up whole frame Eric S Fraga
2015-06-08 16:37 ` Charles Millar
2015-06-08 16:46   ` Kaushal
2015-06-09  7:31     ` e.fraga
2015-06-17  8:24     ` Eric S Fraga
2015-06-17 16:41       ` Subhan Michael Tindall
2015-06-18  7:57         ` Eric S Fraga
2015-06-23 20:31           ` Nicolas Goaziou [this message]
2015-06-25  8:00             ` Eric S Fraga
2015-06-25 12:22               ` Nicolas Goaziou
2015-06-08 20:28 ` Thierry Banel
2015-06-09  9:22 ` Alan Schmitt
2015-06-09  9:43   ` Eric S Fraga
2015-06-18 11:16   ` Xebar Saram
2015-06-18 11:45     ` Alan Schmitt
2015-06-18 11:52       ` Xebar Saram
2015-06-18 14:42         ` Alan Schmitt
     [not found] ` <871thlw193.fsf@gmail.com>
2015-06-09 12:35   ` Bernhard Pröll
2015-06-12  9:27     ` Eric S Fraga

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oak6rwsg.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=SubhanT@familycareinc.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=kaushal.modi@gmail.com \
    --cc=millarc@verizon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).