From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: More clocktable breakage Date: Sun, 14 May 2017 11:10:43 +0200 Message-ID: <87o9uvztv0.fsf@nicolasgoaziou.fr> References: <877f39nr05.fsf@Rainer.invalid> <87d1d0p2qx.fsf@nicolasgoaziou.fr> <87tw5bumck.fsf@Rainer.invalid> <87shkt4tuf.fsf@Rainer.invalid> <8737ct1xyr.fsf@nicolasgoaziou.fr> <87fugt4npu.fsf@Rainer.invalid> <87pofxzctf.fsf@nicolasgoaziou.fr> <87wpa4fjio.fsf@Rainer.invalid> <878tmixsvo.fsf@nicolasgoaziou.fr> <87tw556kxo.fsf@Rainer.invalid> <87vapjgq93.fsf@nicolasgoaziou.fr> <87r307tb9k.fsf@Rainer.invalid> <87pofmflt1.fsf@nicolasgoaziou.fr> <87inle8g5s.fsf@Rainer.invalid> <87vapd6khx.fsf@nicolasgoaziou.fr> <87lgq9hs29.fsf@Rainer.invalid> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d9pYB-0006Ln-1W for emacs-orgmode@gnu.org; Sun, 14 May 2017 05:10:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d9pY7-0004O5-Na for emacs-orgmode@gnu.org; Sun, 14 May 2017 05:10:51 -0400 Received: from relay7-d.mail.gandi.net ([2001:4b98:c:538::200]:39264) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d9pY7-0004Ma-FF for emacs-orgmode@gnu.org; Sun, 14 May 2017 05:10:47 -0400 In-Reply-To: <87lgq9hs29.fsf@Rainer.invalid> (Achim Gratz's message of "Sun, 07 May 2017 12:36:30 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Achim Gratz Cc: emacs-orgmode@gnu.org Hello, Achim Gratz writes: > Yes, put the cursor on the date or time of one of the timestamps and > press S-Up or S-Down. It should increase or decrease the corresponding > element of the timestamp, but instead you'll get an error message: > > org-clocktable-shift: Line needs a :block definition before this command works > > which appears because the timestamp wasn't recognized and the > fallthrough of org-shift* then tries to apply another function that > deals with the :block argument (which isn't present here and shouldn't > be). OK, reproduced. I fixed the issue by extending `org-at-timestamp-p' optional argument while preserving backward-compatibility. The new docstring is: Non-nil if point is inside a timestamp. By default, the function only consider syntactically valid active timestamps. However, the caller may have a broader definition for timestamps. As a consequence, optional argument EXTENDED can be set to the following values `inactive' Include also syntactically valid inactive timestamps. `agenda' Include timestamps allowed in Agenda, i.e., those in properties drawers, planning lines and clock lines. `lax' Ignore context. The function matches any part of the document looking like a timestamp. This includes comments, example blocks... For backward-compatibility with Org 9.0, every other non-nil value is equivalent to `inactive'. When at a timestamp, return the position of the point as a symbol among `bracket', `after', `year', `month', `hour', `minute', `day' or a number of character from the last know part of the time stamp. When matching, the match groups are the following: group 1: year group 2: month group 3: day number group 4: day name group 5: hours, if any group 6: minutes, if any I also updated the callers throughout the code base. >> I start to think that there is no bug in clock tables (but certainly in >> the cache mechanism, probably related to some `before-change-functions' >> and `after-change-functions' misuse there). > > I'm not using any of those unless they already come with Emacs or Org. What I meant is the use of `before-change-functions' and `after-change-functions' is wrong in the caching mechanism, not in your configuration. Anyway, it doesn't matter for the problem at hand. Is your issue solved? Regards, -- Nicolas Goaziou