From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id AHGEFERFGmAaVQAA0tVLHw (envelope-from ) for ; Wed, 03 Feb 2021 06:40:04 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 6B1sEERFGmChLQAA1q6Kng (envelope-from ) for ; Wed, 03 Feb 2021 06:40:04 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A4C1D940627 for ; Wed, 3 Feb 2021 06:40:03 +0000 (UTC) Received: from localhost ([::1]:37056 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7BpZ-0007fz-Ci for larch@yhetil.org; Wed, 03 Feb 2021 01:40:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51590) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7Bo4-0007fj-Mr for emacs-orgmode@gnu.org; Wed, 03 Feb 2021 01:38:28 -0500 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]:40149) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l7Bo0-00043b-Jc for emacs-orgmode@gnu.org; Wed, 03 Feb 2021 01:38:26 -0500 Received: by mail-pj1-x1034.google.com with SMTP id z9so3954765pjl.5 for ; Tue, 02 Feb 2021 22:38:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=0igipY0AQCIbYIYDmYtaaznBiZwABCWAPCDovzKY3bI=; b=aRyPo+iVPA1b3aSx3HyZPxB/7DHseUxGSKK53ACGgsaeSKvzFeB2x9JpNytkXscw+o y3xKdwUerQh10/olnrefYWjRSO81s3ckv5s+PiMjBCYGkvaEbyBvwea0vm7sIfmG5IIs DTB+88C8z3cuVlj6NXtKzThsmM2dxFLHjAkUOMoN7sO6nMsHQhnyNw0YG3S1DQEiVdE9 c2YgHF/5n788NTpvgPWMTk6ZMPoZbCq4vHMlKPTcI55kPZBh18t8hXM1JfMHQooAsSaV CwmAdLgqZSGJ7xELu9BYsCgE8u6nJbYpBN2bOMFE4JxL/3ylqJg3UrQqRNZEsSAiGmIg vNgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=0igipY0AQCIbYIYDmYtaaznBiZwABCWAPCDovzKY3bI=; b=EXS3qR3QgOq0wcHS19OTdE6weYV8Vs7+Dm8dpFA27mqRWdEk+2SoXvJPzPE9zilOFB MZeDfbefjF3As1xQJYqKzoI3pFKNZ9hGaKe910WKJKXzrAcwGd/KasEgTTwamYFH60MF AKawfQuLUDeb/3qawwPk088uc26H3HlQ2aIieUuxoezINH0LxX9GL5YKMDB0Xp1kkry6 1chsUZmhT7LJ9h1NzwxtO0JtFXdL2kyINQLJU12wN5lnf3dAP1nh4JxraW1wTo4IATEE iMt42e9NAfri3twWrO6xGr7Ircj2di/nw7bpKCrRZz9IiiIKTyCoXjkLBdMQ/Jg/D6QC QLWQ== X-Gm-Message-State: AOAM531J2lzP+/NnKwJLUw4FD41lMLGK3km5c/yv40VZHKaWiMREzSyy Q+rQNqQlaDJEfscLlMsYATQ/ynibKJsmHg== X-Google-Smtp-Source: ABdhPJwa25wUvWVYWZ8Ikm78t8jhHRt40i5+IEbiV7v7eRf0bMt9mjdthtxkKCdTD1b5W5w4TRP32w== X-Received: by 2002:a17:90a:4306:: with SMTP id q6mr1706784pjg.138.1612334302876; Tue, 02 Feb 2021 22:38:22 -0800 (PST) Received: from tim-desktop (220-235-5-208.dyn.iinet.net.au. [220.235.5.208]) by smtp.gmail.com with ESMTPSA id b21sm989881pfb.45.2021.02.02.22.38.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Feb 2021 22:38:22 -0800 (PST) References: <874kr6402z.fsf@gmail.com> <87y2o11ef5.fsf@gmail.com> <87eeptfe4u.fsf@gmail.com> <87tuqu1bys.fsf@gmail.com> User-agent: mu4e 1.5.8; emacs 27.1.91 From: Tim Cross To: Christopher Miles Subject: Re: patch: ob-clojure improvements Date: Wed, 03 Feb 2021 17:36:50 +1100 In-reply-to: Message-ID: <87o8h11wrp.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::1034; envelope-from=theophilusx@gmail.com; helo=mail-pj1-x1034.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "emacs-orgmode@gnu.org" Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.06 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=aRyPo+iV; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: A4C1D940627 X-Spam-Score: -3.06 X-Migadu-Scanner: scn0.migadu.com X-TUID: QPZE+Yvkia+R OK. As the patch is over 6 months old, it would be good if the original author can confirm it is still the latest version and if not, re-send the most recent version. Christopher Miles writes: > <#secure method=3Dpgpmime mode=3Dsign> > > I checked this thread, seems the original first email of thread contains = the patch. And it's not merged into Org git yet. > > Tim Cross writes: > > OK, will push it up the todo list. Where can I get the latest version of = the patch or has it been added into the org git repo? > > Christopher Miles writes: > > <#!secure method=3Dpgpmime mode=3Dsign> > > Hi, Tim, popup this thread to request review. =F0=9F=98=84 > > Tim Cross writes: > > I am also interested in ob-clojure and ob-clojurescript improvements. How= ever, right now, I'm a tad busy and haven't had time to review what has bee= n done. Hopefully, can make some time in the next month or so. > > Tim > > stardiviner writes: > > agzam.ibragimov@gmail.com writes: > > There seems to be a bit of lack of interest for these things. But I'm sur= e some people (myself included) would love to see these kinds of improvemen= ts. > > Yes, I rarely saw Clojurians in this mailing list. > > As I said before, I have never participated in contributing to Org source= , some guidance would be appreciated. > > Org Mode has contribution guide here http://orgmode.org/worg/org-contribu= te.html#patches > > Should I keep building it and posting patches? Should I try to go increme= ntally, one small change at a time, or should I just get everything working= first? If it turns out to be a bigger work, should I ask for permission to= work in a branch and get access to pushing things to it? Maybe things just= move slowly, because obviously you can't force maintainers to drop everyth= ing and concentrate effort to get your things in. Maybe I just have to be a= little bit more patient? > > I think a complete work contains many patches should be better, Also writ= e testing if necessary. > > I remember ob-clojure.el code are mostly reviewed by Bastien Guerry. I in= cluded him in Cc: in this email. > > On Sat, Jun 20, 2020 at 1:23 AM stardiviner wrote: > > Glad to see your patch, really useful in some cases. Thanks. > > Ag Ibragimov writes: > > Hi everyone, here's my attempt to add clojure CLI and babashka support fo= r ob-clojure.el - Adds a header parameter to override org-babel-clojure-bac= kend - Adds :args param (right now only used for clojure-cli) > > I have tested it with these minimal cases: > > #+beginsrc clojure :backend clj-cli :args "-Sdeps '{:deps {inflections {:= mvn/version \"0.13.2\"}}}'" (use 'inflections.core) (plural "word") #+endsrc > > #+beginsrc clojure :backend babashka :results output (range 10) #+endsrc > > Please let me know what you think. Any advice is appreciated, since I hav= e never contributed before. Thank you. > > =E2=80=93 [ stardiviner ] I try to make every word tell the meaning that = I want to express. > > Blog: https://stardiviner.github.io/ IRC(freenode): stardiviner, Matrix: = stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3 -- Tim Cross