From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id uNYuC7adh2C8dAAAgWs5BA (envelope-from ) for ; Tue, 27 Apr 2021 07:14:30 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id YH7oBradh2C0egAA1q6Kng (envelope-from ) for ; Tue, 27 Apr 2021 05:14:30 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9C0621E347 for ; Tue, 27 Apr 2021 07:14:29 +0200 (CEST) Received: from localhost ([::1]:35582 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbG3H-0008NQ-RJ for larch@yhetil.org; Tue, 27 Apr 2021 01:14:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60480) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbG2W-0008NG-0O for emacs-orgmode@gnu.org; Tue, 27 Apr 2021 01:13:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44207) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbG2U-0004ct-Jm; Tue, 27 Apr 2021 01:13:38 -0400 Received: from [2a01:e34:ec2b:7150:6ed7:7f91:e8e8:7d37] (port=35324 helo=guerry) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1lbG2U-00084x-2T; Tue, 27 Apr 2021 01:13:38 -0400 Received: by guerry (Postfix, from userid 1000) id 95A731A60EB7; Tue, 27 Apr 2021 07:13:35 +0200 (CEST) From: Bastien To: Kyle Meyer Subject: Re: Bug: [PATCH] define-minor-mode: prefer keyword args [9.4.5 (9.4.5-ga02a3b @ /home/n/.emacs.d/straight/build/org-plus-contrib/)] In-Reply-To: <87wnsofynx.fsf@kyleam.com> (Kyle Meyer's message of "Mon, 26 Apr 2021 18:50:42 -0400") References: <87y2d5mde2.fsf@gmail.com> <87a6plus2v.fsf@gnu.org> <87wnsofynx.fsf@kyleam.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) X-Woof-Bug: fixed Date: Tue, 27 Apr 2021 07:13:35 +0200 Message-ID: <87o8e0s41s.fsf@bzg.fr> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org, No Wayman Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619500469; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=PeD+WeYXEbgAvCcJGHXtKby6sBd/lZ92kY2axkU/VOg=; b=qRhJSy1HFd1EjoSDjIurx0hpcdmjON/XfVNfDwTTr9KS4cpoJHFIQXCOAIF4yZPTeRGMqA ENrqtN9wMZwUgtTKCgeOvoRbayRdRkjfx2OhVtUKISS4/ARcxJaDOugFpVyCFkKNnmJwPo W5uXImyGOSvNgelarmcxSCNdd7ybbdfq8fAZj3ycJJ5CfDUN58cGjkQH0CBk7eHZSuedNC jySVRucDb1CuKzZfDYiy/oaec9gfWnpwwI3DsilDqaLabriORu04dJS9OoqlyDkI9AFVqc i/C/vR47ISgVkowdtcR4Q3Rh9AkBfopClemsSPEiPtDgWZcs7ksxLdUDjb5V6w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619500469; a=rsa-sha256; cv=none; b=Jft/jHJ0l7YPluu4R3foNNxcjNUSes69QKhHF7Mz8gWq0hnTPYEXqdmiL2CxR3fMRA5Xe/ ISpr7NjeSmTO83yQKfMjlRjf3d5UvZMFeftX7ngh6+8UqNvmSqeRgug9ulveVu6pc3ZqcM B+0h0mUUZcltsCcMuk0oe19yYZFWSELUvesFxEjwpVU6kInW/PqhtAdbNTK8nZ6JysFpbO rJgubV9g8WMmvVWCv2wmFSMY3AZxEvNhHNvzb6G0n7SaIcDeItx6x1/0QLcVTbkq7hqcJs F0DmDqnPS9wJOMDYETF1n5SxKlNq1XiHlIXbX52CAAb/QRyuD8yYein4mJoQSQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.95 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 9C0621E347 X-Spam-Score: -2.95 X-Migadu-Scanner: scn0.migadu.com X-TUID: wyMfKrWxOpCK Hi Kyle, Kyle Meyer writes: > Bastien writes: > >> Hi, >> >> thanks for the patch, we do indeed need to move forward for this. >> >> Could you propose the patch against the master branch (not the maint >> branch, since this is not a bugfix) and perhaps fix *all* warnings? > > Thanks, but these were already taken care of by 8c29cbdef (Backport > commit c45bfd3c4 from Emacs, 2021-04-18), which was merged into master > with 664b65344. Er, my bad - I'm marking this "bug" as "fixed" then.