From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id eKKMMIB1nGFusQAAgWs5BA (envelope-from ) for ; Tue, 23 Nov 2021 06:00:48 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id kH9BLIB1nGHKFQAAB5/wlQ (envelope-from ) for ; Tue, 23 Nov 2021 05:00:48 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7748338808 for ; Tue, 23 Nov 2021 06:00:48 +0100 (CET) Received: from localhost ([::1]:34162 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mpNvD-00011r-Mm for larch@yhetil.org; Tue, 23 Nov 2021 00:00:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38478) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpNuG-0000yH-W7 for emacs-orgmode@gnu.org; Mon, 22 Nov 2021 23:59:49 -0500 Received: from out2.migadu.com ([188.165.223.204]:28633) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpNuE-00058y-IL for emacs-orgmode@gnu.org; Mon, 22 Nov 2021 23:59:48 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1637643584; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DTOYx9hX+Gs0Eamb1GF7QvIbDsx7spOie+h24RQNxe0=; b=Khiy/fO9HknJmLTybAYCDmlQaD8qAbPcMxne7k2QocgtGOdLmgNTAXjKPh4A5BSaVeXd5h NDz28FbgFQwU90tahJu9MvPGiG436bbld/reSTaHCYVQs64Zk+ub1kmbwtqeKyrmwC0l+C oHzjeOqjizhtptpPVZigppQ+z5izT4Z2WZSYVIEtuBZH6GEtRp326N64GhS0rgCaoPp3Sc GQ2xWSUqBGnegsq8vr1tsVEQYzfQ5jness6mkrc9QjCD6rhO2XxVG+z4UW+Vayi6OhC6rQ 3GqF+lDbhkPHSO4X+n0+ncEL8MHSTZ0Vui7fy426MXjkYnlYu0N9qmH16RvaDQ== From: Kyle Meyer To: Matt Huszagh Subject: Re: [PATCH] Fix regex for determining image width from attribute In-Reply-To: <87y25fq5d2.fsf@gmail.com> References: <87czmtuy0p.fsf@gmail.com> <87ilwl71gh.fsf@gmail.com> <87a6hxuw0y.fsf@gmail.com> <877dd07fnb.fsf@gmail.com> <8735noqig0.fsf@gmail.com> <87wnl05ag6.fsf@gmail.com> <87y25fq5d2.fsf@gmail.com> Date: Mon, 22 Nov 2021 23:59:42 -0500 Message-ID: <87o86bqxfl.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=188.165.223.204; envelope-from=kyle@kyleam.com; helo=out2.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org, Timothy Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637643648; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=DTOYx9hX+Gs0Eamb1GF7QvIbDsx7spOie+h24RQNxe0=; b=D0dUW8ObXGqhRhLq31fSXn7Hoq4xYNpTLFvoATEt8Zl85gNCwcd4N71qXaxgmmSoROtRXY 3/Kt5aQnIey8CIrDIBHpJ8QXb5lAdj4fbhILTZkhV0q5hkR38l7YuObFQK0cyCmvxvZcFa jmrfnnNWN7NYV+seOfDUIPekaEx/bfJ2oVDDNJiBLM+6BsreZji6tqyWwRbpq90+omPS0m 6cEoV1/H8501XO58VDMRbSdr06J0Ecq8+b10KFv28Q4/2OXaZl3tVozesRp9/NjiYCqiBC WB1hJCcGcNmwi+qtdA7T1NmrKrTqEMLxGoIdKC6F56UWpc9KyODHYqRVYwhFpw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637643648; a=rsa-sha256; cv=none; b=DD73XuKwiTIs6as5NgBLgb8li0zDxdNsAifgK/Y1M48cLkJ3lRep82XNMKgRF1mCg0X2h9 K6jfVHJS2saCQ9ArO2jU3Zco/8/fYvC7yCPFn9RUWvDwpGnF70dMUjQnLrfTlNVmhEvBfA Vqpw6icl4vugtcSuDNFlTVCCFFk6ji+DZYH1oPn8v/g0ELl0lAphIwEkozz1ev/6hL0Yg5 hTnspcpa7bVW3+24/K4Waq9shve1XS4M9cUN1TNObO6d2R6BtGHXq8eTVqXKuvVl1sqMkd eYTctTyPWoEHMeKuqCjpq/2VEVKjq0G0GSMb+gPUXquPGCH3r+PazdKb7ZJrdA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kyleam.com header.s=key1 header.b="Khiy/fO9"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.88 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kyleam.com header.s=key1 header.b="Khiy/fO9"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 7748338808 X-Spam-Score: -1.88 X-Migadu-Scanner: scn0.migadu.com X-TUID: 7B6NPYFX8itY Matt Huszagh writes: > Timothy writes: > >> I=E2=80=99ve just pushed the change I described in 4514a32. This improve= s the >> interpretation of :width attributes and makes a value of =E2=80=9Ct=E2= =80=9D work as discussed. >> I have not prioritised #+attr_org for now, but that sounds like a change= we >> could make in the future. > > Thanks Timothy. However, I think this change may have some issues. It > seems that it unbalances parentheses. This also no longer sets width > (so, e.g., (floatp width) won't work). Maybe attr-width was intended to > be renamed to width? Are you seeing the same? I'm not sure either, but this syntax error brings down the whole tree, so I've pushed 27f26f782 to resolve it. Timothy, please check my guess at what the intended code was.