From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id oKNKNUwo7mKDbgAAbAwnHQ (envelope-from ) for ; Sat, 06 Aug 2022 10:37:33 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id OGBlNEwo7mLGXAAAG6o9tA (envelope-from ) for ; Sat, 06 Aug 2022 10:37:32 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B4B5041D7 for ; Sat, 6 Aug 2022 10:37:32 +0200 (CEST) Received: from localhost ([::1]:41304 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oKFJL-0003Fg-EF for larch@yhetil.org; Sat, 06 Aug 2022 04:37:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57136) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oKFI0-0003EI-Tu for emacs-orgmode@gnu.org; Sat, 06 Aug 2022 04:36:08 -0400 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]:41505) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oKFHv-0001Ik-Ko for emacs-orgmode@gnu.org; Sat, 06 Aug 2022 04:36:08 -0400 Received: by mail-pl1-x62f.google.com with SMTP id p18so4472524plr.8 for ; Sat, 06 Aug 2022 01:36:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=VswyBG7mXR4QCYVIkwWqDZeY2c06iw3j/z/VoNCxz/M=; b=LNJ4jLsEqtiQLME/jbRiUeMuvXpjOfvMsAFLn5N6vWYiH0IG9UexveIBolKgoAzVPz wG9WNQmBVuajp93Z1M0U7XVBnSZOYXmsYCvo0INVnLKfc1A/KXslMPqj4i4Jd1OEgoQq j3TRfx3zpTqo52CneaSekg3rKXYn03i90XmpKmUlP9GzRwg2xQ48mnyU77G6Nb48Jr3K h/HFXDn622GHA7vC9/qn2ccPU68xc/wOVf05aTCbLxI5eREKF4eSmDWjLhdLVXX3nr2r cUh2mOk0chcUtZPeVyzpR6K0jTkE/jzHpfoxSGiRpui0O0J5v5i+T6b7SzLYlH5uDUeO dS8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=VswyBG7mXR4QCYVIkwWqDZeY2c06iw3j/z/VoNCxz/M=; b=T83V7Ys4hFPTXrszsf9R1+yTco42l2RRCqEupwvL9Yu1lAMv4CCTW2ak+BDTJB+joE X1YOjyuIuA4EdEhS/HacN+NgSbeC4PpzzJOJ9WLArlVDTIhZU4Uyv4vmrzAxbi/z66RL dBAkP5cbNIrH9u03wZeIynvnSNSz5oyav8K2lNfqw2yHd4egz2yHP9u4ypG717yL0G2y 3jcLCEV/DzS0nRR3jOJS+ojReNG0vKMIshaYuiAkROvhdw+Z59ML3MH6hsaJ7iK2n77y FjlQT1D9oWH1x05uqNWiYDBGAXEeCxUaMT+iozIMEGqhef/0qpqbmIYlcsgjBqHLU6NS /1nw== X-Gm-Message-State: ACgBeo0LmS3hw3btqU/dJ8VY5YKVwM7sklI8YOnGgHizmaS21L5GdPAN CNS2DTO5mhGw5hs284hjX78= X-Google-Smtp-Source: AA6agR6NfiVkrzIoczBRskJMuEOzgoKsiUm5uTzSEvMuX4Qb2fLbT7mFMJcFI+SFmNjghMyctp8nZg== X-Received: by 2002:a17:90a:6007:b0:1f3:3527:609e with SMTP id y7-20020a17090a600700b001f33527609emr11577008pji.52.1659774961854; Sat, 06 Aug 2022 01:36:01 -0700 (PDT) Received: from localhost ([1.83.155.1]) by smtp.gmail.com with ESMTPSA id q19-20020a170902bd9300b0016c4f0065b4sm4378436pls.84.2022.08.06.01.36.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Aug 2022 01:36:01 -0700 (PDT) From: Ihor Radchenko To: Joseph Turner Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] org-contrib/babel/languages/ob-doc-plantuml.org: ASCII output In-Reply-To: <20220805214214.25723-1-joseph@breatheoutbreathe.in> References: <20220805214214.25723-1-joseph@breatheoutbreathe.in> Date: Sat, 06 Aug 2022 16:37:04 +0800 Message-ID: <87o7wxlqdr.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::62f; envelope-from=yantar92@gmail.com; helo=mail-pl1-x62f.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" Authentication-Results: aspmx1.migadu.com; none X-Migadu-Scanner: scn1.migadu.com X-TUID: KROTdR47D0bq Joseph Turner writes: > Document the new functionality of ob-plantuml to insert ASCII diagrams > directly in the buffer. Thanks! > -=PlantUML= requires a working [[https://www.java.com/en/download/][Java]] installation and access to the > -=plantuml.jar= component. A working [[https://graphviz.org/][GraphViz]] installation is required > -for many diagrams. > +=PlantUML= blocks can be executed in one of three ways, requiring either > + > +- a working [[https://www.java.com/en/download/][Java]] installation and access to the =plantuml.jar= component or > +- the =plantuml= executable available from your distribution's package manager or > +- a connection to a remote [[https://github.com/plantuml/plantuml-server][PlantUML server]] I do not think that ob-plantuml.el supports server connections. We may need to clarify that server part and plantuml-* variables have nothing to do with ob-plantuml per se. Otherwise, the patch looks good. -- Ihor Radchenko, Org mode contributor, Learn more about Org mode at https://orgmode.org/. Support Org development at https://liberapay.com/org-mode, or support my work at https://liberapay.com/yantar92