From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 2H6PN+6E9GLUSAAAbAwnHQ (envelope-from ) for ; Thu, 11 Aug 2022 06:26:22 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 4Dx+N+6E9GJhBwAA9RJhRA (envelope-from ) for ; Thu, 11 Aug 2022 06:26:22 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 74398D3F4 for ; Thu, 11 Aug 2022 06:26:22 +0200 (CEST) Received: from localhost ([::1]:39892 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLzm1-0007yQ-Il for larch@yhetil.org; Thu, 11 Aug 2022 00:26:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45994) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLzla-0007xJ-95 for emacs-orgmode@gnu.org; Thu, 11 Aug 2022 00:25:54 -0400 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]:40871) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oLzlX-0008F0-0L for emacs-orgmode@gnu.org; Thu, 11 Aug 2022 00:25:53 -0400 Received: by mail-pl1-x62c.google.com with SMTP id x23so16005022pll.7 for ; Wed, 10 Aug 2022 21:25:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc; bh=/n2GawhVR/RanKHCcNZ/sEKYKp2tKXL3VFDVgNPHWNE=; b=QR0ep3mQ2wEzwMa3C3gsFWW9zjZ1PnvY3RFj9RRNoiXBB5nibA8VFpv5J8ji/fe+Ae xRPR9/rEw+LrO6CfW5eyQsbl8xuxvzsimYwTmNeHAkeV+o/oIN1OPKp060NaPVkUnU3B rdABkA2edeKNKWqp+A2a/cKVA/SND+iG8PBVpPSWMUdJRXHi4WisZCHOBksdgERpCtpD frDsGgC9NU8fdPlLyI16zcRvDVDKQpZkgEWfe6TUC70loyIAvegV2dWa+7l/VyDDUOef zNKG4qVgFL14utnVEvoCmFCRZ+BLCZux4SeTcIFes4g2f/k4ikiLAtfRC+ZwNwp0/eHD XL8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc; bh=/n2GawhVR/RanKHCcNZ/sEKYKp2tKXL3VFDVgNPHWNE=; b=JikTjE7Q++OZpG2yKkiC3Pc5OdnJ3w5Wo/ZaKysqGu3/lvRWUwQNF2OhG9u4iKTUKD 2pLokUVvH3ennyPUwK2kroXAt3SCMVrjvX+zIa/+iWGjssOShRUPc2tXNM3sp+v9dnCr YsBwD9lsXjqFyZ/Fegcy1amCcmZdkMMf/qqfI5FXFgKQ9ZHrlAkH58lcLTWIpSUn+2ax sQPrGTd5eKFzQSTkCGyx0d6pTR5pKjU/WGsXSRJhd0DOHydk7n78y+LjFNQSo1oGFeIR mmZtPhfSATMpdDl6/y0EcL1sUeZsk/ZdaYPNxX1X+MQ38rGQqJLi6LtxTt0MHn/qoOWX OnSQ== X-Gm-Message-State: ACgBeo2w0PoPjbf8TnlC/BvzuDLBPaegOmuAlMxDzOxBucff655SRWOj iok8DLtt3viIfE8fDMd5GJiaTZ5ZgXZWQMrk X-Google-Smtp-Source: AA6agR4e9fjr+sGt9Pr1vBkUsFZHarrnud1KDc0wWW6MZ3mwcdSm04riMXZ6P9pevTXJd5PR0nqPTw== X-Received: by 2002:a17:902:7fce:b0:16e:e3e7:b12f with SMTP id t14-20020a1709027fce00b0016ee3e7b12fmr30214070plb.56.1660191948521; Wed, 10 Aug 2022 21:25:48 -0700 (PDT) Received: from localhost ([115.154.175.57]) by smtp.gmail.com with ESMTPSA id b10-20020a170902650a00b0016f14abb9b2sm13862608plk.125.2022.08.10.21.25.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Aug 2022 21:25:47 -0700 (PDT) From: Ihor Radchenko To: Hraban Luyat Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] ob-tangle.el: fix =?utf-8?Q?=E2=80=98=3Acomments_nowe?= =?utf-8?Q?b=E2=80=99?= double linking In-Reply-To: References: <01070182484e44f3-f0fd271a-def3-4c86-961f-9a4bb63949d5-000000@eu-central-1.amazonses.com> <87wnbvtcz9.fsf@localhost> Date: Thu, 11 Aug 2022 12:26:51 +0800 Message-ID: <87o7wr9zhw.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::62c; envelope-from=yantar92@gmail.com; helo=mail-pl1-x62c.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1660191982; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=/n2GawhVR/RanKHCcNZ/sEKYKp2tKXL3VFDVgNPHWNE=; b=teNI4ApI6f5A5p+Ya251OLUnHHma/tEUVVqqAxmRh8HP+n7dUn4OSOMYKfiDOeI9F2PR9B EKdIWr89uFL2DfF6mngbv0CululmcpDdb+0ZcXX14zG+raKAL11F1bBmjh/AqnZwexTw+b naJe8WToy5QDRdOI2uFjlXNE11ZLrwyfqTFE2mKmZoyGqt5zeY4Elm+X9oHNiU1tHjO25v CzC7aoAIq5Ijc2sTJzCzfLuZTpKYxXJEgpPcuuu8nBOOUwOPvFhjJyw6R4AkCPaLNhQdIw DzAkny852EW69BFDMnhXf5vKKJIr9jbKiHII5YdHm2v6WPy1nEhQn07ahw+7TA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1660191982; a=rsa-sha256; cv=none; b=TDe4vq/iVV7YX8mHgIht32XvTXEov15fLUefWQJ05zRCU7l+dtkoFsxidn/Fl7OI2cUlkj rYVvKGXxQK1ZsP60J0rGQkgKm22gUEYMiFsz9BIkBGVbhtpGvtMv6x2sEsyzL88iwcWPJI CVNxIeNk4efBfVokf97IYkAv/HlCHsEqcK/pDI3kBcUIVYCwr/jrziYQhZtjMm87VQH3Rk l49CCPmUKU2wpAwE45XET3rU2HsGiRqiNJu4Qk5EBfDAS31Tr7GrS+iKKbFemhMWALHt9k jAkie3AuBglvA3hja1b3ENyL1UVTSQXq5vlRpdTeHzSwjyf7j14bhqkMBh2DSg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=QR0ep3mQ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.88 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=QR0ep3mQ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 74398D3F4 X-Spam-Score: -1.88 X-Migadu-Scanner: scn1.migadu.com X-TUID: DX36s+oweVCE Hraban Luyat writes: >> Is there any problem with the following? >> >> (alist-get :tangle params) > > This bit of code was moved, I didn't write it. The original code uses a > variable `src-tfile' which isn't available here, so I reused the > definition of that variable (which is (cdr (assq yada yada))). When > creating this patch, I tried to change as little as possible, to keep > everything the same as much as I can. Don't write new code, just move > existing code around. > > The (cdr (assq ..)) is used in some other places, too; maybe it's worth > a separate refactor if we want to change that? I'd rather keep this > patch as isolated as possible. I suspect that alist-get was not there in Emacs 24. Otherwise, alist-get with no optional parameters is just a wrapper for (cdr (assq...)) We can change it, though I do not see this as a big problem. > @Ihor: I have rebased the patch and attached it. Sorry, but the patch still does not apply on my side onto the current main branch. -- Ihor Radchenko, Org mode contributor, Learn more about Org mode at https://orgmode.org/. Support Org development at https://liberapay.com/org-mode, or support my work at https://liberapay.com/yantar92