[BUG] org-cite-insert error on style part

[BUG] org-cite-insert error on style part

[Kierin Bell]

Hello,
When I run 'org-cite-insert' with point before the initial colon of a
citation element, Emacs signals a 'wrong-number-of-arguments' error.

For example, 'C-c C-x @' with point below X in:
  X
[cite:@author2022]

...Produces:
Debugger entered--Lisp error: (wrong-number-of-arguments (1 . 1) 0)
  org-cite-basic--complete-style()
  #f(compiled-function (context arg) #<bytecode
   0x1056dfe0ba7a573c>)((citation (:style nil :begin 94 :post-blank 0 \\
   :end 111 :contents-begin 100 :contents-end 110 :parent (paragraph  \\
   (:begin 94 :end 111 :contents-begin 94 :contents-end 111           \\
   :post-blank 0 :post-affiliated 94 :parent nil)))) nil)
  org-cite-insert(nil)
  funcall-interactively(org-cite-insert nil)
  call-interactively(org-cite-insert nil nil)
  command-execute(org-cite-insert)

The problem appears to be that my Emacs build doesn't like that
'org-cite-make-insert-processor' is calling
'org-cite-basic--complete-style' without any arguments on line 1636 of
oc.el:
                     (style (funcall select-style)))

'org-cite-insert' in other contexts works as expected, including with a
prefix argument when point is outside of any citation, which creates a
new citation by doing completion for a style.

This may be more of an issue with my setup; I'm not an Elisp expert. But
I'm filing it as a bug because I'm getting an error that is reproducible
even with 'emacs -Q'.

GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo version 1.16.0)
Org mode version 9.5.4 (release_9.5.4-17-g6e991f @ /usr/local/share/emacs/29.0.50/lisp/org/)

Thanks,
Kierin

Re: [BUG] org-cite-insert error on style part

[Ihor Radchenko]

Kierin Bell <bellkierin@gmail.com> writes:

> Hello,
> When I run 'org-cite-insert' with point before the initial colon of a
> citation element, Emacs signals a 'wrong-number-of-arguments' error.
>
> For example, 'C-c C-x @' with point below X in:
>   X
> [cite:@author2022]
>
> ...Produces:
> Debugger entered--Lisp error: (wrong-number-of-arguments (1 . 1) 0)
>   org-cite-basic--complete-style()

Thanks for reporting!
Fixed on main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=2b9f9646ef919534dcbf61174f31440f1cd1214c

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>