From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id eHhkI0xPa2NiuwAAbAwnHQ (envelope-from ) for ; Wed, 09 Nov 2022 07:57:16 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id qGtWIkxPa2MkigAAG6o9tA (envelope-from ) for ; Wed, 09 Nov 2022 07:57:16 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2CB7D37972 for ; Wed, 9 Nov 2022 07:57:16 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1osf14-0002yf-0J; Wed, 09 Nov 2022 01:56:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osf11-0002yB-SU for emacs-orgmode@gnu.org; Wed, 09 Nov 2022 01:56:51 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osf0x-0006g1-PB for emacs-orgmode@gnu.org; Wed, 09 Nov 2022 01:56:50 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 93C4724010D for ; Wed, 9 Nov 2022 07:56:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1667977004; bh=8vHAwYYdHqaAjsoEhWYwK5PxNiJTWIyy8+kfjGXwAK8=; h=From:To:Cc:Subject:Date:From; b=ZarhLag0BBUjve+7VSQ2Zp3AhG/R1bpRTZDYJ4R1ao1hMjDCFdsn5s1Xdj9Pa12HD c5ur7BTJscycbYFEVrEH/yDsV3OoacSM+/OKADHPA7KPBDvREU7U5EdI0rI0yEPC4J TLtijyCk50YCVPB3JVzVGjGEb472OG+3GOwo1t6AlRM25IpYoIjfF/Qtw997TvXQpR ETnHRBCiIM5brszS7PdCR2UdhmYlfIhc7e5qlSskV1cBWZ7iRrNav66hhMAVHYOX5s m2NjgBws6DLFZAbdQ5g3wjl7SOXO6O9ANQVicxavnu4co4h8WtXIYi2dyjkFP+iin9 CG9x4Mpab+Ztg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N6bNl1PCSz6tpl; Wed, 9 Nov 2022 07:56:38 +0100 (CET) From: Ihor Radchenko To: Detlef Steuer Cc: emacs-orgmode@gnu.org Subject: Re: [patch] improved: add TTL as defcustom to ox-icalendar In-Reply-To: <20220103123253.6bb48655@hsu-hh.de> References: <20211230225919.1a660666@hsu-hh.de> <20220102142849.0af72bcb@hsu-hh.de> <20220103084141.72d2f384@hsu-hh.de> <20220103123253.6bb48655@hsu-hh.de> Date: Wed, 09 Nov 2022 06:57:17 +0000 Message-ID: <87o7tgaa42.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1667977036; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=lPd39PeWun7ewV19UZoyP/m4uQWltDIGCDg1sRwREbg=; b=j+jn1H268PeI1FCybgKCS21eXsbXnppLun6XoFtVxvLxFX2l4c/6fwT9N0Sio7Xhd3gl6E xYyCyMSpRJQp+gWB6Hv76jMnQixjHUDX6Zob2ywAL/kqn0jLL0xD7fbW5u9Qf+e47Rb5V8 46/m+qYFmNzaaWN/dp5WsndTHV4YhtEBa1Rxwi0r7NKHMt7bY8wuEUZp4/4YgBhRohoGas U3ZaK+I0GTzUq0BW+TJGaxGll0qNLwJLiI/m6caUHImL4n7BDP+oRFK1aLoUXvSe7Lqd8y FChvMZPQBd6v0xuNNWsP+q/i5ZRa3crUHhDk6kj36QnybW3HuDgxu4DO9aTQqw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1667977036; a=rsa-sha256; cv=none; b=jRXsAkFMbdRp0q28FLi+Tl84+b2tTsSTaF9Smyu1A3cOwo4SHKyCHpzO22yF55wbe/VLs4 /04EW+/N/t7qVEkkzU3MlE3T37vkV5XKyR5cJ/+6r4qAPzi1XXg5+oNAk6MmXdqor8fR32 AWRn/zrxKO2SI7a9E0wVz4eVo5HR1pIpkC6mscM1DBuJYVkefG33Ksobw7XzZQpBTu5mZr VSoGpVIDK0Vqr5eqXVFXQn8DccKy3Fg4l2eskeQeRF+0s/bCThfPXN9w+X2UnU3bevqXJc Et+f3yesLia/2hQaVqSpP06sdDAlUxKLu+66WfcHIinYDxHE388SXJ3Jyr0Oyg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=ZarhLag0; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.82 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=ZarhLag0; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 2CB7D37972 X-Spam-Score: -4.82 X-Migadu-Scanner: scn0.migadu.com X-TUID: iv90IDLgTOoB Detlef Steuer writes: >> I think, it is better to wait for comments from an ox-icalendar user. > > Sure. Sorry for the late reply. I am not a user, but will the patch looks reasonable in general. >> I am afraid, you will be tired trying to convince me that TTL should >> be overridden for all users (not to say that I am not a maintainer). > > No, that wasn't my intention. Just tried to explain. I agree that it is not a good idea to force-override server defaults. Instead, I'd prefer the defcustom to default to nil (no TTL inserted) and other possible values documented and listed in :type defcustom argument. >> >> https://orgmode.org/worg/org-contribute.html for some hints >> >> addressed to contributors. >> >> I am not completely sure, but you patch may exceed "TINYCHANGE" >> limit, so signing FSF copyright papers may be a prerequisite to >> accept your patch. >> > > Hmm, probably a good idea anyway. The patch is on the edge, probably still acceptable without copyright assignment. If you have it, it would be much better though. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at