emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [BUG] :safe predicate for org-link-abbrev-alist does not make sense
@ 2023-02-08  6:35 Qiantan Hong
  2023-02-08 13:48 ` Ihor Radchenko
  0 siblings, 1 reply; 2+ messages in thread
From: Qiantan Hong @ 2023-02-08  6:35 UTC (permalink / raw)
  To: emacs-orgmode@gnu.org

The predicate is currently
(lambda (val)
(pcase val
(`(,(pred stringp) . ,(pred stringp)) t)
(_ nil)))

This returns true for pairs like ("wiki" . "Blabla"), but such values are invalid.
org-link-abbrev-alist need to be an ALIST. For any ALIST, the above predicate
returns NIL.


Best,
Qiantan





^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [BUG] :safe predicate for org-link-abbrev-alist does not make sense
  2023-02-08  6:35 [BUG] :safe predicate for org-link-abbrev-alist does not make sense Qiantan Hong
@ 2023-02-08 13:48 ` Ihor Radchenko
  0 siblings, 0 replies; 2+ messages in thread
From: Ihor Radchenko @ 2023-02-08 13:48 UTC (permalink / raw)
  To: Qiantan Hong; +Cc: emacs-orgmode@gnu.org

Qiantan Hong <qthong@stanford.edu> writes:

> The predicate is currently
> (lambda (val)
> (pcase val
> (`(,(pred stringp) . ,(pred stringp)) t)
> (_ nil)))
>
> This returns true for pairs like ("wiki" . "Blabla"), but such values are invalid.
> org-link-abbrev-alist need to be an ALIST. For any ALIST, the above predicate
> returns NIL.

Thanks for reporting!
Fixed, on main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=6cbbf4cdb

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-02-08 13:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-08  6:35 [BUG] :safe predicate for org-link-abbrev-alist does not make sense Qiantan Hong
2023-02-08 13:48 ` Ihor Radchenko

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).