From: Karl Fogel <kfogel@red-bean.com>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: Bastien <bzg@gnu.org>, Org Mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Fix warning about using `eq' to compare strings.
Date: Wed, 01 Nov 2023 11:29:23 -0500 [thread overview]
Message-ID: <87o7gdzbbw.fsf@red-bean.com> (raw)
In-Reply-To: <87msvxdei5.fsf@localhost> (Ihor Radchenko's message of "Wed, 01 Nov 2023 09:11:46 +0000")
On 01 Nov 2023, Ihor Radchenko wrote:
>Bastien <bzg@gnu.org> writes:
>> Karl Fogel <kfogel@red-bean.com> writes:
>>
>>> Hi, everyone. Small fix attached -- it just makes a warning
>>> go
>>> away.
>>
>> Applied against the main branch, thanks!
>
>Unfortunately, fixing this warning breaks org-table logic and
>tests.
>See previous discussion in
>https://list.orgmode.org/orgmode/20230827214320.46754-1-salutis@me.com/
Oh my goodness. That is... sigh. Wow.
This is now beyond the "trivial fix" level of effort that I was
prepared to invest to make this warning go away. Like Rudolf
Adamkovič and others before him, I now retire to my country
estate, to simultaneously lick my wounds and rest on my laurels
(which I guess is better than licking my laurels and resting on my
wounds).
Thank you for noticing, and for adding the FIXME later.
Best regards,
-Karl
next prev parent reply other threads:[~2023-11-01 16:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 16:08 [PATCH] Fix warning about using `eq' to compare strings Karl Fogel
2023-10-31 20:40 ` Bastien
2023-11-01 9:11 ` Ihor Radchenko
2023-11-01 9:16 ` Bastien
2023-11-01 9:28 ` Ihor Radchenko
2023-11-01 10:00 ` Bastien Guerry
2023-11-01 16:29 ` Karl Fogel [this message]
2023-11-01 17:59 ` tomas
2023-11-02 8:14 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7gdzbbw.fsf@red-bean.com \
--to=kfogel@red-bean.com \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).