From: Ihor Radchenko <yantar92@posteo.net>
To: dark.key8799@151e.ai
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Re: Suggestion to add hook to be run when org-indent completes a buffer's initialization
Date: Tue, 02 Jan 2024 11:15:02 +0000 [thread overview]
Message-ID: <87o7e43s21.fsf@localhost> (raw)
In-Reply-To: <afc8f2e9-ce6b-461e-8855-1715cf3845f2@app.fastmail.com>
dark.key8799@151e.ai writes:
>> I do not see why we shouldn't add such a hook. Patches welcome!
>
> Would this work?
Yes, but please address some minor comments.
> +(defcustom org-indent-post-buffer-init-hook nil
> + "Hook run after org-indent finishes initializing a buffer.
> +The function(s) in in this hook must accept a single argument representing
> +the initialized buffer."
> + :group 'org-indent
> + :type 'hook)
By convention, abnormal hooks (hooks that require arguments) are named
as *-functions, not *-hook.
Also, when adding new customizations, we generally announce them in
etc/ORG-NEWS.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2024-01-02 11:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-30 5:24 Suggestion to add hook to be run when org-indent completes a buffer's initialization dark.key8799
2023-12-31 14:42 ` Ihor Radchenko
2024-01-02 10:56 ` [PATCH] " dark.key8799
2024-01-02 11:15 ` Ihor Radchenko [this message]
2024-01-02 15:53 ` dark.key8799
2024-01-03 15:38 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7e43s21.fsf@localhost \
--to=yantar92@posteo.net \
--cc=dark.key8799@151e.ai \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).