emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] org-info-other-documents: Fix defcustom safe-local-variable property
@ 2024-12-19 21:20 Joseph Turner
  2024-12-22 17:01 ` Ihor Radchenko
  0 siblings, 1 reply; 3+ messages in thread
From: Joseph Turner @ 2024-12-19 21:20 UTC (permalink / raw)
  To: Org Mode Mailing List

[-- Attachment #1: Type: text/plain, Size: 29 bytes --]

Minor fix.  Thanks!

Joseph


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-info-other-documents-Fix-defcustom-safe-local-va.patch --]
[-- Type: text/x-diff, Size: 783 bytes --]

From 5451da0d798f104e9a0d87445c516fd89e473a38 Mon Sep 17 00:00:00 2001
From: Joseph Turner <joseph@breatheoutbreathe.in>
Date: Thu, 19 Dec 2024 13:16:50 -0800
Subject: [PATCH] org-info-other-documents: Fix defcustom safe-local-variable
 property

:safe should be a function.
---
 lisp/ol-info.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/ol-info.el b/lisp/ol-info.el
index fa9b23b84..b4e993a0b 100644
--- a/lisp/ol-info.el
+++ b/lisp/ol-info.el
@@ -149,7 +149,7 @@ (defcustom org-info-other-documents
   :group 'org-link
   :type '(alist :key-type string :value-type string)
   :package-version '(Org . "9.7")
-  :safe t)
+  :safe #'listp)
 
 (defun org-info-map-html-url (filename)
   "Return URL or HTML file associated to Info FILENAME.
-- 
2.46.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] org-info-other-documents: Fix defcustom safe-local-variable property
  2024-12-19 21:20 [PATCH] org-info-other-documents: Fix defcustom safe-local-variable property Joseph Turner
@ 2024-12-22 17:01 ` Ihor Radchenko
  2024-12-22 23:52   ` Joseph Turner
  0 siblings, 1 reply; 3+ messages in thread
From: Ihor Radchenko @ 2024-12-22 17:01 UTC (permalink / raw)
  To: Joseph Turner; +Cc: Org Mode Mailing List

Joseph Turner <joseph@breatheoutbreathe.in> writes:

> Minor fix.  Thanks!

Thanks!
I applied an alternative fix, addressing all the instances of the same
problem in Org code.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=f2b6478de9

Canceled. (this patch)

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] org-info-other-documents: Fix defcustom safe-local-variable property
  2024-12-22 17:01 ` Ihor Radchenko
@ 2024-12-22 23:52   ` Joseph Turner
  0 siblings, 0 replies; 3+ messages in thread
From: Joseph Turner @ 2024-12-22 23:52 UTC (permalink / raw)
  To: Ihor Radchenko; +Cc: Org Mode Mailing List

Even better.  Thank you!

Joseph

Ihor Radchenko <yantar92@posteo.net> writes:

> Joseph Turner <joseph@breatheoutbreathe.in> writes:
>
>> Minor fix.  Thanks!
>
> Thanks!
> I applied an alternative fix, addressing all the instances of the same
> problem in Org code.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=f2b6478de9
>
> Canceled. (this patch)


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-12-22 23:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-19 21:20 [PATCH] org-info-other-documents: Fix defcustom safe-local-variable property Joseph Turner
2024-12-22 17:01 ` Ihor Radchenko
2024-12-22 23:52   ` Joseph Turner

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).