From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernt Hansen Subject: Re: Bug: / RET filter no longer auto-excludes FILETAGS [6.33trans (release_6.33f.34.gf806)] Date: Thu, 26 Nov 2009 06:21:09 -0500 Message-ID: <87my294jmi.fsf@gollum.intra.norang.ca> References: <200911251854.nAPIsQjM001980@gollum.intra.norang.ca> <87r5rl4ku1.fsf@gollum.intra.norang.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NDcPV-00006h-Pr for emacs-orgmode@gnu.org; Thu, 26 Nov 2009 06:21:17 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NDcPS-000053-Td for emacs-orgmode@gnu.org; Thu, 26 Nov 2009 06:21:17 -0500 Received: from [199.232.76.173] (port=36590 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NDcPS-0008WR-NA for emacs-orgmode@gnu.org; Thu, 26 Nov 2009 06:21:14 -0500 Received: from mho-01-ewr.mailhop.org ([204.13.248.71]:55393) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NDcPS-0007Qw-H4 for emacs-orgmode@gnu.org; Thu, 26 Nov 2009 06:21:14 -0500 In-Reply-To: (Carsten Dominik's message of "Thu\, 26 Nov 2009 12\:03\:24 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Carsten Dominik Cc: emacs-orgmode@gnu.org Carsten Dominik writes: > On Nov 26, 2009, at 11:55 AM, Bernt Hansen wrote: > >> Carsten Dominik writes: >> >>> On Nov 25, 2009, at 7:54 PM, Bernt Hansen wrote: >>> >>>> >>>> My auto exclude functions are inline below: >>>> >>>> (defun bh/org-auto-exclude-function (tag) >>>> (and (cond >>>> ((string= tag "@home") >>>> (bh/working-p)) >>>> ((string= tag "@office") >>>> (not (bh/working-p))) >>>> ((string= tag "MARK") >>>> (not (bh/mark-p))) >>>> ((or (string= tag "@errand") (string= tag "PHONE")) >>>> (let ((hour (nth 2 (decode-time)))) >>>> (or (< hour 8) (> hour 21))))) >>>> (concat "-" tag))) >>>> >>> >>> do you get it back to when when replacing "MARK" with "mark" and >>> "PHONE" wiht "phone"? >> >> Yes. When I make the tags lowercase in the function above it works >> again. > > The docstring of org-agenda-auto-exclude-function does mention this, > but it is indeed a change from John's original code - so it was not in > the docstring when you wrote this function.. Ah! Oops. I was bad and didn't read the contents of commit c6186f4 (Check all represented tags in agenda for auto-exclusion, 2009-11-20) before submitting the bug report. I'll try to remember to do that next time. This change should probably be described in the upcoming release notes just so anyone else that already has the function defined won't get caught by it but I'm sure you're already planning to do that :) I can't find anything in the Changelog mentioning the case change. Thanks for the clarification! Bernt