From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Maus Subject: Re: [PATCH] fix infinite loop in csv table import Date: Tue, 20 Jul 2010 07:30:01 +0200 Message-ID: <87mxtmk9eu.wl%dmaus@ictsoc.de> References: <87r5izxkfp.fsf@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: multipart/mixed; boundary="===============1082542570==" Return-path: Received: from [140.186.70.92] (port=46112 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ob5P8-0006SF-HY for emacs-orgmode@gnu.org; Tue, 20 Jul 2010 01:30:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Ob5P3-0000Ki-T5 for emacs-orgmode@gnu.org; Tue, 20 Jul 2010 01:30:10 -0400 Received: from mysql1.xlhost.de ([213.202.242.106]:48934) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ob5P3-0000KJ-Mw for emacs-orgmode@gnu.org; Tue, 20 Jul 2010 01:30:05 -0400 In-Reply-To: <87r5izxkfp.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Eric Schulte Cc: Org Mode --===============1082542570== Content-Type: multipart/signed; boundary="pgp-sign-Multipart_Tue_Jul_20_07:29:59_2010-1"; micalg=pgp-sha256; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit --pgp-sign-Multipart_Tue_Jul_20_07:29:59_2010-1 Content-Type: text/plain; charset=US-ASCII Eric Schulte wrote: >Hi, >I've just noticed that I get an infinite loop when importing csv tables >into Org-mode tables. For example calling > (org-table-convert-region (point-min) (point-max) '(4)) >from inside of a simple text file containing the following >--8<---------------cut here---------------start------------->8--- >1,2,3 >1 >2 >3 >5 >--8<---------------cut here---------------end--------------->8--- >results in an infinite loop. The attached patch fixes this issue [1], >however it seems weird that this would just surface now, given that the >code in question has been in the repo since last fall This patch looks good to me: If the end of the region happens to be end-of-buffer point will never be greater than end and the loop loops forever. Best, -- David -- OpenPGP... 0x99ADB83B5A4478E6 Jabber.... dmjena@jabber.org Email..... dmaus@ictsoc.de --pgp-sign-Multipart_Tue_Jul_20_07:29:59_2010-1 Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iF4EABEIAAYFAkxFNFgACgkQma24O1pEeOZH6gEA2N6IhXHjRPqFDWqrJAbWI8Kp AiM4QUvpQmk8JBqR7JYA/2O1ovbmbNpXUAacJ4i4nDS4JSQf1NI5MWZ3AvNYd1x4 =UNup -----END PGP SIGNATURE----- --pgp-sign-Multipart_Tue_Jul_20_07:29:59_2010-1-- --===============1082542570== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode --===============1082542570==--