From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [BUG] Dynamic scoping of project-plist in preparation-function Date: Wed, 22 Jun 2016 15:34:17 +0200 Message-ID: <87mvmd8i06.fsf@saiph.selenimh> References: <87pora9u30.fsf@saiph.selenimh> <87wplhiwnn.fsf@systemreboot.net> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37780) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFiIZ-0004yg-Nh for emacs-orgmode@gnu.org; Wed, 22 Jun 2016 09:34:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFiIT-0000tJ-TL for emacs-orgmode@gnu.org; Wed, 22 Jun 2016 09:34:30 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:57483) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFiIT-0000t2-Mj for emacs-orgmode@gnu.org; Wed, 22 Jun 2016 09:34:25 -0400 In-Reply-To: <87wplhiwnn.fsf@systemreboot.net> (Arun Isaac's message of "Wed, 22 Jun 2016 11:37:40 +0530") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Arun Isaac Cc: "Emacs-orgmode@gnu.org" Hello, Arun Isaac writes: >> 2. Require preparation functions to accept one parameter, the project >> plist. > > I think adding project-plist as a parameter to preparation functions is > definitely more elegant. Done in 5cd793c. > But, I also came across this old thread where it was noted that making > project-plist a proper parameter, instead of it being dynamically scoped > into the preparation function, would break a lot of code. Bad code deserves to be broken anyway. More seriously, the fix is trivial, so I don't think this is an issue. Thank you for the feedback. Regards, -- Nicolas Goaziou