From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien Guerry <bzg@gnu.org>
Subject: Re: Backward incompatible outline-invisible-p change in emacs master
 for Org
Date: Wed, 14 Jun 2017 19:02:13 +0200
Message-ID: <87mv9ay02y.fsf@bzg.fr>
References: <CAFyQvY1050kjG+eNFctuXjruud3C18h4VxA2Nih_QqRo7puv1Q@mail.gmail.com>
	<87a85i2nji.fsf@nicolasgoaziou.fr>
	<CAFyQvY2fGdezRKdF5QZ78X89B2Ma-xp3oJQJsDqsgf5Xx7f13w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44489)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <bzg@gnu.org>)
	id 1dLBga-0003nW-VN
	for emacs-orgmode@gnu.org; Wed, 14 Jun 2017 13:02:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bzg@gnu.org>) id 1dLBgW-0002sK-Qz
	for emacs-orgmode@gnu.org; Wed, 14 Jun 2017 13:02:25 -0400
In-Reply-To: <CAFyQvY2fGdezRKdF5QZ78X89B2Ma-xp3oJQJsDqsgf5Xx7f13w@mail.gmail.com>
	(Kaushal Modi's message of "Wed, 14 Jun 2017 14:56:55 +0000")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: Paul Rankin <hello@paulwrankin.com>, emacs-org list <emacs-orgmode@gnu.org>, Nicolas Goaziou <mail@nicolasgoaziou.fr>

Hi Kaushal,

thanks for putting me in the loop.

Kaushal Modi <kaushal.modi@gmail.com> writes:

> I also find an org-invisible-p2 function, but it's not clear why it
> does a (backward-char =C2=A01) before doing invisibility check.. and that
> too eventually relies on outline-visible-p. (Turns out this function
> has a long history:=C2=A0http://orgmode.org/cgit.cgi/org-mode.git/commit/?
> id=3D93a4128a6fe47b4e05c0a7cb3ec14878b41d6000=C2=A0)

The question is: why this patch in the first place?  Paul authored it
and I committed it, so I should know--but I don't.  Maybe Paul know or
you know better?

> Here's a patch for the above proposed solution.

This looks fine, but I'd rather revert the faulty Emacs commit if
it is not necessary.

Until Paul enlighten us, I'll have a deeper look.

Thanks,

--=20
 Bastien