From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] make 'org-at-date-range-p work like org-at-timestamp-p Date: Mon, 18 Mar 2019 22:43:13 +0100 Message-ID: <87mulrsvta.fsf@nicolasgoaziou.fr> References: <23692.5492.62319.323977@AGAME7.local> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([209.51.188.92]:38491) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h602V-0002ZP-KT for emacs-orgmode@gnu.org; Mon, 18 Mar 2019 17:43:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h602U-0008VG-PT for emacs-orgmode@gnu.org; Mon, 18 Mar 2019 17:43:23 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:55723) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h602U-0008SF-EJ for emacs-orgmode@gnu.org; Mon, 18 Mar 2019 17:43:22 -0400 In-Reply-To: <23692.5492.62319.323977@AGAME7.local> (Thomas Plass's message of "Fri, 15 Mar 2019 22:13:24 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Thomas Plass Cc: emacs-orgmode@gnu.org Hello, thunk2@arcor.de (Thomas Plass) writes: > it's counter-intuitive that 'org-at-date-range-p doesn't work like > 'org-at-timestamp-p when point is on the leading bracket of a range. > Witness (^ = point) > > <2019-12-30 Mo 12:00> > ^ (org-at-timestamp-p) => t > > <2019-12-30 Mo 12:00>--<2019-12-31 Di 09:00> > ^ (org-at-timestamp-p) => t > ^ (org-at-date-range-p) => t > ^ (org-at-date-range-p) => nil > > Is the attached patch OK? Thank you. I think the incompatibility is deeper than that. IMO, `org-at-date-range-p' should obey to the same arguments as `org-at-timestamp-p'. IOW, a rewrite is in order. Regards, -- Nicolas Goaziou