From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id cNRrHb95VF8mUwAA0tVLHw (envelope-from ) for ; Sun, 06 Sep 2020 05:55:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id kFApGb95VF9QTAAAB5/wlQ (envelope-from ) for ; Sun, 06 Sep 2020 05:55:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0664B9404C4 for ; Sun, 6 Sep 2020 05:55:11 +0000 (UTC) Received: from localhost ([::1]:57636 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEndu-00059I-18 for larch@yhetil.org; Sun, 06 Sep 2020 01:55:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60378) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEndb-00059C-Kz for emacs-orgmode@gnu.org; Sun, 06 Sep 2020 01:54:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46753) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEndb-0007lT-CM; Sun, 06 Sep 2020 01:54:51 -0400 Received: from [2a01:e35:2fe1:f780:d122:b755:abc5:9fce] (port=35418 helo=guerry) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1kEnda-0002Qy-VY; Sun, 06 Sep 2020 01:54:51 -0400 Received: by guerry (Postfix, from userid 1000) id 0D9651A60D69; Sun, 6 Sep 2020 07:54:50 +0200 (CEST) From: Bastien To: No Wayman Subject: Re: [PATCH] org-add-planning-info: respect caller's given time [9.3.7 (release_9.3.7-716-g3d4876 @ /home/n/.emacs.d/straight/build/org/)] Organization: GNU References: <87zh6rfvmi.fsf@gmail.com> <87ft7wdxjl.fsf@gnu.org> <871rjgi4mb.fsf@gmail.com> Date: Sun, 06 Sep 2020 07:54:50 +0200 Message-ID: <87mu23mout.fsf@bzg.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: +NoyTLvpedd7 No Wayman writes: > Bastien writes: > >> Applied in maint as c7abcd514, thanks. > > Thanks, Bastien. I noticed org-end-time-was-given is bound similarly. > This binding doesn't affect my usage, but I wonder if it is necessary. > If you think it isn't, I'd be happy to submit another patch removing > it. Actually, "optimistic merging" was too optimistic and your change breaks a test, as Kyle reported here: https://orgmode.org/list/87tuwb35wh.fsf@kyleam.com/ If you see what's going on, can you report? -- Bastien