From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id sK5DMOmf+WTyWQAAG6o9tA:P1 (envelope-from ) for ; Thu, 07 Sep 2023 12:03:22 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id sK5DMOmf+WTyWQAAG6o9tA (envelope-from ) for ; Thu, 07 Sep 2023 12:03:21 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 877805843D for ; Thu, 7 Sep 2023 12:03:21 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=l4zDsWOs; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694081001; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=HqSwTX4sOegzajb3hlUEvzuDcdJwm1QYGx8MdBNKEL4=; b=GQwM49i6TMLmVEjbjxvsJnCR7Ps1K2TCFUhjXk45IaTTfeYK5b7t5rloPwcD8TcWeEpwrM v8GdNNRO7JKgZNVjm82wywd/UWAdsLBXMDM24tu/nkfgsY184OZCMCzWaCXlf4qgXyGpVe TiSlrqy/srwG9zeDx1/4eDGsBUG8zO4qaz+rLFaIUmvNeVWAGd8N7TUqtA1sdCxrO8ikSO hcSdv6x6UiYZ1OqzPYSbhf9DCB0KUtIlx1PGUbAwxsvTpBoN25ncJs0JqNxdubEGLy2TIk /BXqiZ1giREuTQ5AY0Zui4qARdXefZfa5hDfFIRr15m0lP/zpOf6sEycMYS9sQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694081001; a=rsa-sha256; cv=none; b=UMgUijtq0y8Tmll5i6rmLHEdAUZIMJZxKKsa6dXQznbF8pQ4nptUlEzz+XPIC+/E34ukyy ZYlI3bPpL05mRsZYTsAkFQ11yZrKNByg6PouDDhzXdASE30I83VUM5C+3s7Cvb+0RUpPv1 1Bj6zWA6YmcvvssMsTYdns6fW/gTkskPXmfwaiBcnSUiYMlxE9vNcJakqnTnHSaXJs3IaK He+mjHuZHsldnKg7CIJOQ1ESSsxJJRew+kkj6oT3N6UymGJ9faJSM0IUzFupjUFrHBl2xk uoJAiO/1YdBnnLKe6bzD0HuHPevYBw6IhXGt8Y7yP9HGZjICxoMOzcNl5npOuA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=l4zDsWOs; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qeBql-0005Fj-Eg; Thu, 07 Sep 2023 06:02:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeBqT-0005Eb-7t for emacs-orgmode@gnu.org; Thu, 07 Sep 2023 06:02:46 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeBqM-0002bG-GN for emacs-orgmode@gnu.org; Thu, 07 Sep 2023 06:02:38 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 8EE62240107 for ; Thu, 7 Sep 2023 12:02:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1694080952; bh=5c4riDdXtJ/eWnH1Zw2iVhDHUW8iG3+2X0iAPq6EGDI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=l4zDsWOs6dT/Z7qajUYg6g22RUX8J38gnxbg9bDAaPjFqtJ02q/lqjGLv9NwfqFj6 bkqnWOVZwth7M3mNifsu1+iszCkM6VwDB7IQqtV+cbwYOTiomvn2hS13wn/dU8mjLI pvSTitEvQkkAhpy4p22cN4dfA/XcxZlSVhpIzWO50axgs6/bB/GR5sQLwSZxOwSpsB gS8SZ8TiAbP6JM3Su/kzN8VqiGUmTdBjmv/CRwh9oVSsJGB1gKORgv+PFj9k4hy2pO SsmUq/rBMjUDfuOENmcTbjP7gXcfYsvDIzZH62G3Xv3+WEZYUHB2a+Z2TO9aRUb5PN UHKQVzpZinj5A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RhFCr1Mgzz6tsb; Thu, 7 Sep 2023 12:02:32 +0200 (CEST) From: Ihor Radchenko To: Sebastian Miele Cc: Eli Zaretskii , 65734@debbugs.gnu.org, emacs-orgmode@gnu.org Subject: Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] In-Reply-To: <87o7if72b2.fsf@whxvd.name> References: <87il8pao4l.fsf@whxvd.name> <87tts8vrpb.fsf@localhost> <83h6o84yz1.fsf@gnu.org> <87ledju2j7.fsf@localhost> <87o7if72b2.fsf@whxvd.name> Date: Thu, 07 Sep 2023 10:03:22 +0000 Message-ID: <87msxypafp.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx2.migadu.com X-Spam-Score: -9.09 X-Migadu-Queue-Id: 877805843D X-Migadu-Spam-Score: -9.09 X-TUID: UkEJ4lugvMF4 Sebastian Miele writes: >> I think there is misunderstanding. `combine-after-change-calls' will not >> affect the two-step modification of the kill ring, if we put it around >> `kill-whole-line'. Or do I miss something? > > I tried to wrap the problematic portion of `kill-whole-line' into > `combine-after-change-calls'. It seems to have no effect. The > after-change function `org-fold-core--fix-folded-region' still gets > called twice, not fixing the bug. I did not dig deeper, because the > stuff that makes `combine-after-change-calls' work at least partially > goes in C and seems to be scattered over several places. Oops. Of course, I meant `combine-change-calls'. `combine-after-change-calls' does not always have effect. In particular, Org sets `before-change-functions' effectively disabling the macro you tried. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at