emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: David Maus <dmaus@ictsoc.de>
To: "Sébastien Vauban" <wxhgmqzgwmuf@spammotel.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Problem when org-capturing text from French email
Date: Fri, 16 Jul 2010 19:06:22 +0200	[thread overview]
Message-ID: <87lj9bmk4x.wl%dmaus@ictsoc.de> (raw)
In-Reply-To: <87fwzjld0f.fsf@mundaneum.com>


[-- Attachment #1.1.1: Type: text/plain, Size: 1690 bytes --]

Sébastien Vauban wrote:
>Hello,

>Here a trace of the problem that occurs when I capture some text from an
>email, for archive purpose.

>--8<---------------cut here---------------start------------->8---
>Debugger entered--Lisp error: (args-out-of-range 35 42)
>  format("%.30s" #("Re: Gestionnaire de r\x00e9visions pour \x00e9\ diteur LaTeX sous Windows" 20 29 (charset iso-8859-15) 35 42 (charset iso-8859-15)))
>  org-replace-escapes("Email from %f: %.30s" (("%c") ("%F" . #("Denis Bitouz\x00e9 <dbitouze.no@spam.wanadoo.fr>" 6 13 ...)) ("%f" . "Denis Bitouz\x00e9") ("%T") ("%t" . "?") ("%s" . #("Re: Gestionnaire de r\x00e9visions pour \x00e9\ diteur LaTeX sous Windows" 20 29 ... 35 42 ...)) ("%m" . "20100715150256.4f029e84@drums")))
>  org-email-link-description()
>  org-gnus-store-link()
>  run-hook-with-args-until-success(org-gnus-store-link)
>  org-store-link(nil)
>  org-capture(nil)
>  call-interactively(org-capture nil nil)
>--8<---------------cut here---------------end--------------->8---

>I guess it's somehow related to the accents in the mail title?  Not sure I
>understand the details of the trace, but the capture works in many other
>cases, so the accents could be the differentiating factor (I don't have enough
>history, yet, to assert this).

Your message's user agent tells me, that you use Emacs 23.1 -- and
this looks like Emacs bug #5306[1].

The Attached patch avoids this bug by removing all text properties from
the subject (the same is done in org-wl.el).

HTH,
  -- David

[1] http://debbugs.gnu.org/cgi/bugreport.cgi?bug=
-- 
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... dmjena@jabber.org
Email..... dmaus@ictsoc.de

[-- Attachment #1.1.2: 0001-Remove-text-properties-of-subject-to-avoid-Emacs-bug.patch --]
[-- Type: text/plain, Size: 2416 bytes --]

From 2b253d742ad584a0cf8fb5f9c4e413e2456f662b Mon Sep 17 00:00:00 2001
From: David Maus <dmaus@ictsoc.de>
Date: Fri, 16 Jul 2010 19:02:38 +0200
Subject: [PATCH] Remove text properties of subject to avoid Emacs bug #3506

* org-gnus.el (org-gnus-store-link): Remove text properties of subject
to avoid Emacs bug #3506.
---
 lisp/org-gnus.el |   20 ++++++++++++--------
 1 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/lisp/org-gnus.el b/lisp/org-gnus.el
index a41de2e..e135563 100644
--- a/lisp/org-gnus.el
+++ b/lisp/org-gnus.el
@@ -120,22 +120,26 @@ If `org-store-link' was called with a prefix arg the meaning of
 
    ((memq major-mode '(gnus-summary-mode gnus-article-mode))
     (let* ((group gnus-newsgroup-name)
-   	   (header (with-current-buffer gnus-summary-buffer
+	   (header (with-current-buffer gnus-summary-buffer
 		     (gnus-summary-article-header)))
 	   (from (mail-header-from header))
 	   (message-id (org-remove-angle-brackets (mail-header-id header)))
 	   (date (mail-header-date header))
 	   (subject (mail-header-subject header))
-           (to (cdr (assq 'To (mail-header-extra header))))
-           newsgroups x-no-archive desc link)
+	   (to (cdr (assq 'To (mail-header-extra header))))
+	   newsgroups x-no-archive desc link)
+      ;; Remove text properties of subject string to avoid Emacs bug
+      ;; #3506
+      (set-text-properties 0 (length subject) nil subject)
+
       ;; Fetching an article is an expensive operation; newsgroup and
       ;; x-no-archive are only needed for web links.
       (when (org-xor current-prefix-arg org-gnus-prefer-web-links)
-        ;; Make sure the original article buffer is up-to-date
-        (save-window-excursion (gnus-summary-select-article))
-        (setq to (or to (gnus-fetch-original-field "To"))
-              newsgroups (gnus-fetch-original-field "Newsgroups")
-              x-no-archive (gnus-fetch-original-field "x-no-archive")))
+	;; Make sure the original article buffer is up-to-date
+	(save-window-excursion (gnus-summary-select-article))
+	(setq to (or to (gnus-fetch-original-field "To"))
+	      newsgroups (gnus-fetch-original-field "Newsgroups")
+	      x-no-archive (gnus-fetch-original-field "x-no-archive")))
       (org-store-link-props :type "gnus" :from from :subject subject
 			    :message-id message-id :group group :to to)
       (setq desc (org-email-link-description)
-- 
1.7.1


[-- Attachment #1.2: Type: application/pgp-signature, Size: 230 bytes --]

[-- Attachment #2: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

  reply	other threads:[~2010-07-16 17:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-16 14:25 Problem when org-capturing text from French email Sébastien Vauban
2010-07-16 17:06 ` David Maus [this message]
2010-07-16 20:13   ` Sébastien Vauban
2010-07-17  6:40     ` David Maus
2010-07-17 20:20       ` Sébastien Vauban
2010-07-18  9:47       ` Patchwork: Patch 146 Accepted Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lj9bmk4x.wl%dmaus@ictsoc.de \
    --to=dmaus@ictsoc.de \
    --cc=emacs-orgmode@gnu.org \
    --cc=wxhgmqzgwmuf@spammotel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).