emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Eric Schulte" <schulte.eric@gmail.com>
To: Erik Iverson <eriki@ccbr.umn.edu>
Cc: Detlef Steuer <detlef.steuer@gmx.de>, emacs-orgmode@gnu.org
Subject: Re: Re: [PATCH] Latest git pull has bug in (org-babel-remove-temporary-directory)
Date: Fri, 27 Aug 2010 09:45:47 -0600	[thread overview]
Message-ID: <87lj7svz2s.fsf@gmail.com> (raw)
In-Reply-To: <4C77DA27.4040902@ccbr.umn.edu> (Erik Iverson's message of "Fri, 27 Aug 2010 10:30:47 -0500")

Fixed, Thanks -- Eric

Erik Iverson <eriki@ccbr.umn.edu> writes:

> Hello,
>
> It looks like the delete-directory bug was fixed, but
> on emacs 23.2 at least, (delete-file) only takes one
> argument, so org-babel-remove-temporary-directory is still
> throwing an error in my case, since we have:
>
> 	      (delete-file file nil)
>
> --Erik
>
>
>
> Detlef Steuer wrote:
>> Hi Eric,
>>
>> I have to confirm that bug.
>> Org-mode as of today, emacs 23.1.1.
>>
>> Here is, what my *MESSAGES* buffer tells:
>> CONTENTS...done
>> (No files need saving)
>> org-babel-remove-temporary-directory: Wrong number of arguments: delete-directory, 2
>> When done with a buffer, type C-x #
>> Auto-saving...done
>>
>>
>> Ciao
>> Detlef
>>
>> On Thu, 26 Aug 2010 06:14:26 -0600
>> "Eric Schulte" <schulte.eric@gmail.com> wrote:
>>
>>> Hi Noorul,
>>>
>>> Can I ask what error the directory deletion is causing for you?
>>>
>>> I have the following delete-directory in my Emacs (latest from Git)
>>>
>>> ,----[delete-directory]
>>> | delete-directory is an interactive compiled Lisp function in
>>> | `files.el'.
>>> | | (delete-directory DIRECTORY &optional RECURSIVE TRASH)
>>> | | Delete the directory named DIRECTORY.  Does not follow
>>> symlinks.
>>> | If RECURSIVE is non-nil, all files in DIRECTORY are deleted as well.
>>> | TRASH non-nil means to trash the directory instead, provided
>>> | `delete-by-moving-to-trash' is non-nil.
>>> | | When called interactively, TRASH is t if no prefix argument is
>>> | given.  With a prefix argument, TRASH is nil.
>>> | | [back]
>>> `----
>>>
>>> The second argument to `delete-directory' ensures that subdirectories
>>> are recursively deleted.  Are you using a different version of Emacs
>>> (maybe XEmacs?) in which `delete-directory' accepts a different number
>>> of arguments?
>>>
>>> Thanks -- Eric
>>>
>>> Noorul Islam <noorul@noorul.com> writes:
>>>
>>>> Latest pull is throwing error while quitting emacs.
>>>>
>>>> Here is the patch to fix this.
>>>>
>>>> ob.el:  Fix minor bug
>>>>
>>>> * lisp/ob.el (org-babel-remove-temporary-directory) : Pass correct number of
>>>> arguments to (delete-directory)
>>>>
>>>> Thanks and Regards
>>>> Noorul
>>>>
>>>> diff --git a/lisp/ob.el b/lisp/ob.el
>>>> index 33dbfef..32e2a54 100644
>>>> --- a/lisp/ob.el
>>>> +++ b/lisp/ob.el
>>>> @@ -1679,7 +1679,7 @@ of `org-babel-temporary-directory'."
>>>>  (defun org-babel-remove-temporary-directory ()
>>>>    "Remove `org-babel-temporary-directory' on Emacs shutdown."
>>>>    (when (boundp 'org-babel-temporary-directory)
>>>> -    (delete-directory org-babel-temporary-directory t)))
>>>> +    (delete-directory org-babel-temporary-directory)))
>>>>   (add-hook 'kill-emacs-hook
>>>> org-babel-remove-temporary-directory)
>>>>  _______________________________________________
>>>> Emacs-orgmode mailing list
>>>> Please use `Reply All' to send replies to the list.
>>>> Emacs-orgmode@gnu.org
>>>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>>> _______________________________________________
>>> Emacs-orgmode mailing list
>>> Please use `Reply All' to send replies to the list.
>>> Emacs-orgmode@gnu.org
>>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>>>
>>
>>
>>
>> _______________________________________________
>> Emacs-orgmode mailing list
>> Please use `Reply All' to send replies to the list.
>> Emacs-orgmode@gnu.org
>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

      reply	other threads:[~2010-08-27 15:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-26  8:28 [PATCH] Latest git pull has bug in (org-babel-remove-temporary-directory) Noorul Islam
2010-08-26 12:14 ` Eric Schulte
2010-08-26 12:29   ` Noorul Islam
2010-08-26 13:25     ` Eric Schulte
2010-08-26 22:37       ` Seweryn
2010-08-26 13:31   ` Detlef Steuer
2010-08-27 15:30     ` Erik Iverson
2010-08-27 15:45       ` Eric Schulte [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lj7svz2s.fsf@gmail.com \
    --to=schulte.eric@gmail.com \
    --cc=detlef.steuer@gmx.de \
    --cc=emacs-orgmode@gnu.org \
    --cc=eriki@ccbr.umn.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).