From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] Make org-[beginning|end]-of-line respect visual-line-mode Date: Tue, 06 Nov 2012 18:30:47 +0100 Message-ID: <87liee7i60.fsf@gmail.com> References: <871ug68y1b.fsf@gmail.com> <20121106172704.GA26302@c3po> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:46404) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TVn3G-0007e9-VW for emacs-orgmode@gnu.org; Tue, 06 Nov 2012 12:35:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TVn3F-0002dl-Ol for emacs-orgmode@gnu.org; Tue, 06 Nov 2012 12:35:02 -0500 Received: from mail-wi0-f171.google.com ([209.85.212.171]:43388) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TVn3F-0002b2-Dj for emacs-orgmode@gnu.org; Tue, 06 Nov 2012 12:35:01 -0500 Received: by mail-wi0-f171.google.com with SMTP id hj13so3241547wib.12 for ; Tue, 06 Nov 2012 09:35:00 -0800 (PST) In-Reply-To: <20121106172704.GA26302@c3po> (Toby Cubitt's message of "Tue, 6 Nov 2012 18:27:04 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Toby Cubitt writes: > I'm confused. Which variable are you talking about here? `line-move-visual' > Anyway, I see that `visual-line-mode's sets `line-move-visual' to t > buffer-locally. So checking only `line-move-visual' in > `org-beginning-of-line' is fine... > > ...which strongly suggests that the recent fix to `org-end-of-line' is > wrong. Shouldn't it also be checking `line-move-visual' and not > `visual-line-mode', like `org-beginning-of-line'? Doesn't `visual-line-mode' set C-e to `end-of-visual-line'? As I tried to explain, unless I'm mistaken, `line-move-visual' has nothing to do with beginning or end of current line. Regards,