emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [bug] commit 5512bedee breaks insert diary in agenda
@ 2014-08-19 20:14 Eric S Fraga
  2014-08-19 20:18 ` Eric S Fraga
  2014-08-22 13:51 ` Bastien
  0 siblings, 2 replies; 4+ messages in thread
From: Eric S Fraga @ 2014-08-19 20:14 UTC (permalink / raw)
  To: emacs-orgmode

Hello,

changes made on 28 July, commit 5512bedee, breaks insert diary
functionality. In particular, "i d" in the agenda inserts the new entry
in the wrong place in a date-tree diary org file.

Reverting this commit fixes the problem.

I haven't looked at the code to understand why, partly because I'm not
sure what problem this commit was meant to fix.

thanks,
eric
-- 
: Eric S Fraga (0xFFFCF67D), Emacs 24.4.50.1, Org release_8.3beta-237-gcc6aa4

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [bug] commit 5512bedee breaks insert diary in agenda
  2014-08-19 20:14 [bug] commit 5512bedee breaks insert diary in agenda Eric S Fraga
@ 2014-08-19 20:18 ` Eric S Fraga
  2014-08-22 13:51 ` Bastien
  1 sibling, 0 replies; 4+ messages in thread
From: Eric S Fraga @ 2014-08-19 20:18 UTC (permalink / raw)
  To: emacs-orgmode

On Tuesday, 19 Aug 2014 at 21:14, Eric S Fraga wrote:
> Hello,
>
> changes made on 28 July, commit 5512bedee, breaks insert diary
> functionality. In particular, "i d" in the agenda inserts the new entry
> in the wrong place in a date-tree diary org file.

I forgot to add that the new entry is also demoted (to use the org
terminology) relative to any previous entry in the date where it is
placed.

-- 
: Eric S Fraga (0xFFFCF67D), Emacs 24.4.50.1, Org release_8.3beta-237-gcc6aa4

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [bug] commit 5512bedee breaks insert diary in agenda
  2014-08-19 20:14 [bug] commit 5512bedee breaks insert diary in agenda Eric S Fraga
  2014-08-19 20:18 ` Eric S Fraga
@ 2014-08-22 13:51 ` Bastien
  2014-08-22 14:34   ` Eric S Fraga
  1 sibling, 1 reply; 4+ messages in thread
From: Bastien @ 2014-08-22 13:51 UTC (permalink / raw)
  To: Eric S Fraga; +Cc: Nikolai Weibull, emacs-orgmode

Hi Eric,

Eric S Fraga <e.fraga@ucl.ac.uk> writes:

> changes made on 28 July, commit 5512bedee, breaks insert diary
> functionality. In particular, "i d" in the agenda inserts the new entry
> in the wrong place in a date-tree diary org file.
>
> Reverting this commit fixes the problem.

Reverted, thanks for reporting this.

Nikolai, if you can rework this patch:
http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=5512bedee

so that it fixes the problem we discussed without introducing
the bug Eric reported, please go ahead.

Thanks,

-- 
 Bastien

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [bug] commit 5512bedee breaks insert diary in agenda
  2014-08-22 13:51 ` Bastien
@ 2014-08-22 14:34   ` Eric S Fraga
  0 siblings, 0 replies; 4+ messages in thread
From: Eric S Fraga @ 2014-08-22 14:34 UTC (permalink / raw)
  To: Bastien; +Cc: Nikolai Weibull, emacs-orgmode

On Friday, 22 Aug 2014 at 15:51, Bastien wrote:
> Hi Eric,
>
> Eric S Fraga <e.fraga@ucl.ac.uk> writes:
>
>> changes made on 28 July, commit 5512bedee, breaks insert diary
>> functionality. In particular, "i d" in the agenda inserts the new entry
>> in the wrong place in a date-tree diary org file.
>>
>> Reverting this commit fixes the problem.
>
> Reverted, thanks for reporting this.

Thanks.

-- 
: Eric S Fraga (0xFFFCF67D), Emacs 24.4.50.1, Org release_8.3beta-246-g77d0da

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-08-22 14:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-19 20:14 [bug] commit 5512bedee breaks insert diary in agenda Eric S Fraga
2014-08-19 20:18 ` Eric S Fraga
2014-08-22 13:51 ` Bastien
2014-08-22 14:34   ` Eric S Fraga

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).