emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Marcin Borkowski <mbork@mbork.pl>
To: Nick Dokos <ndokos@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: An issue with org-agenda-todo-list-sublevels
Date: Wed, 16 Dec 2015 09:20:48 +0100	[thread overview]
Message-ID: <87lh8uajof.fsf@mbork.pl> (raw)
In-Reply-To: <87a8pbupiv.fsf@pierrot.dokosmarshall.org>



On 2015-12-16, at 02:54, Nick Dokos <ndokos@gmail.com> wrote:

> Marcin Borkowski <mbork@mbork.pl> writes:
>
>> On 2015-12-14, at 21:48, Nick Dokos <ndokos@gmail.com> wrote:
>>
>>> Marcin Borkowski <mbork@mbork.pl> writes:
>>>
>>>>> On 2015-12-12, at 09:53, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
>>>>>
>>>>>> You can use a dedicated function in `org-agenda-skip-function' for that
>>>>>> (e.g., ignore task if one of its parents is a done task).
>>>>
>>>> OK, so it doesn't work (probably because I'm doing something wrong...)
>>>>
>>>> I did this:
>>>>
>>>> (defun mbork/org-agenda-skip-if-parent-done ()
>>>>   "Return t if any of the parents of the current entry is a DONE
>>>>   item."
>>>>   (save-excursion
>>>>     (catch 'done
>>>>       (while (org-up-heading-safe)
>>>> 	(if (org-entry-is-done-p)
>>>> 	    (throw 'done t))))))
>>>>
>>>> (setq org-agenda-custom-commands
>>>>       '(("n"
>>>> 	 "Agenda and TODOs"
>>>> 	 ((agenda "")
>>>> 	  (alltodo "" ((org-agenda-skip-function #'mbork/org-agenda-skip-if-parent-done)))))))
>>>>
>>>> and I see this:
>>>>
>>>> and: Wrong type argument: integer-or-marker-p, t
>>>>
>>>> What may be the problem?  How do I even debug this?
>>>>
>>>
>>> Are you testing it with emacs -q -l /path/to/min/org-init.el?
>>> If not, you probably should: I don't get any errors with the
>>> stuff above in my minimal org file, which leads me to suspect
>>> it's something in (the rest of) your configuration.
>>
>> Strange.  I have the same error even with emacs -q, with minimal Org
>> config - the above function and one simple agenda file, containing this:
>>
>> * DONE done
>> ** TODO todo
>>
>> Org-mode version 8.2.10 (release_8.2.10 @ /usr/local/share/emacs/25.0.50/lisp/org/)
>>
>> Any hints?
>>
>> Here's the debugger output:
>>
>> Debugger entered--Lisp error: (wrong-type-argument integer-or-marker-p t)
>>   goto-char(t)
>>   (and (setq to (or (org-agenda-skip-eval org-agenda-skip-function-global) (org-agenda-skip-eval org-agenda-skip-function))) (goto-char to))
>
> Not so strange: I probably did not hit the (throw 'done t) in your
> function. The spec says that the function has to return a position
> in the buffer:
>
> ,----
> | org-agenda-skip-function is a variable defined in ‘org-agenda.el’.
> | Its value is nil
> | 
> |   This variable may be risky if used as a file-local variable.
> | 
> | Documentation:
> | Function to be called at each match during agenda construction.
> | If this function returns nil, the current match should not be skipped.
> | Otherwise, the function must return a position from where the search
> | should be continued.
> `----

Stupid me.  Thanks.

-- 
Marcin Borkowski
http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski
Faculty of Mathematics and Computer Science
Adam Mickiewicz University

      reply	other threads:[~2015-12-16  8:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-10 23:26 An issue with org-agenda-todo-list-sublevels Marcin Borkowski
2015-12-12  8:53 ` Nicolas Goaziou
2015-12-12 11:00   ` Marcin Borkowski
2015-12-14 19:17     ` Marcin Borkowski
2015-12-14 20:48       ` Nick Dokos
2015-12-15 23:33         ` Marcin Borkowski
2015-12-16  1:54           ` Nick Dokos
2015-12-16  8:20             ` Marcin Borkowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lh8uajof.fsf@mbork.pl \
    --to=mbork@mbork.pl \
    --cc=emacs-orgmode@gnu.org \
    --cc=ndokos@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).