From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adam Porter Subject: Re: [PATCH] Add option to automatically align tags in agenda view Date: Tue, 08 Aug 2017 13:42:52 -0500 Message-ID: <87lgmtnbo3.fsf@alphapapa.net> References: <87poc7o50r.fsf@alphapapa.net> <87bmnrthag.fsf@kyleam.com> <87k22fnr3o.fsf@alphapapa.net> <878tivt4p1.fsf@kyleam.com> <87wp6em4z0.fsf@alphapapa.net> <8760dxudlw.fsf@kyleam.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34622) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1df9TA-0005r5-F7 for emacs-orgmode@gnu.org; Tue, 08 Aug 2017 14:43:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1df9T6-0007oL-Hj for emacs-orgmode@gnu.org; Tue, 08 Aug 2017 14:43:08 -0400 Received: from [195.159.176.226] (port=43971 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1df9T6-0007nv-Aw for emacs-orgmode@gnu.org; Tue, 08 Aug 2017 14:43:04 -0400 Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1df9Sy-0004HX-2L for emacs-orgmode@gnu.org; Tue, 08 Aug 2017 20:42:56 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org --=-=-= Content-Type: text/plain Kyle Meyer writes: --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-org-agenda.el-Add-option-to-automatically-align-tags.patch Content-Description: patch >From ea3007a8b35d727f71860bd7697808f90d5e1e66 Mon Sep 17 00:00:00 2001 From: Adam Porter Date: Mon, 7 Aug 2017 08:50:26 -0500 Subject: [PATCH] org-agenda.el: Add option to automatically align tags in agenda * lisp/org-agenda.el: (org-agenda-tags-column): Add 'auto setting. (org-agenda-align-tags): Handle automatic alignment. * etc/ORG-NEWS: Document this new setting. TINYCHANGE --- etc/ORG-NEWS | 4 ++++ lisp/org-agenda.el | 24 ++++++++++++++++++------ 2 files changed, 22 insertions(+), 6 deletions(-) diff --git a/etc/ORG-NEWS b/etc/ORG-NEWS index 6361923..0aa0844 100644 --- a/etc/ORG-NEWS +++ b/etc/ORG-NEWS @@ -112,6 +112,10 @@ docstrings. **** New variable : ~org-deadline-past-days~ See docstring for details. **** Binding C-c C-x < for ~org-agenda-set-restriction-lock-from-agenda~ +**** New auto-align default setting for =org-agenda-tags-column= + +=org-agenda-tags-column= can now be set to ='auto=, which will automatically align tags to the right edge of the window. This is now the default setting. + *** New value for ~org-publish-sitemap-sort-folders~ The new ~ignore~ value effectively allows toggling inclusion of diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el index c8097de..93148d0 100644 --- a/lisp/org-agenda.el +++ b/lisp/org-agenda.el @@ -1886,13 +1886,21 @@ When this is the symbol `prefix', only remove tags when (defvaralias 'org-agenda-remove-tags-when-in-prefix 'org-agenda-remove-tags) -(defcustom org-agenda-tags-column -80 +(defcustom org-agenda-tags-column 'auto "Shift tags in agenda items to this column. -If this number is positive, it specifies the column. If it is negative, -it means that the tags should be flushright to that column. For example, --80 works well for a normal 80 character screen." +If set to `auto', tags will be automatically aligned to the right +edge of the window. + +If set to a positive number, tags will be left-aligned to that +column. If set to a negative number, tags will be right-aligned +to that column. For example, -80 works well for a normal 80 +character screen." :group 'org-agenda-line-format - :type 'integer) + :type '(choice + (const :tag "Automatically align to right edge of window" auto) + (integer :tag "Specific column" -80)) + :package-version '(Org . "9.1") + :version "26.1") (defvaralias 'org-agenda-align-tags-to-column 'org-agenda-tags-column) @@ -8959,7 +8967,11 @@ If FORCE-TAGS is non nil, the car of it returns the new tags." (defun org-agenda-align-tags (&optional line) "Align all tags in agenda items to `org-agenda-tags-column'." - (let ((inhibit-read-only t) l c) + (let ((inhibit-read-only t) + (org-agenda-tags-column (if (eq 'auto org-agenda-tags-column) + (- (window-text-width)) + org-agenda-tags-column)) + l c) (save-excursion (goto-char (if line (point-at-bol) (point-min))) (while (re-search-forward "\\([ \t]+\\)\\(:[[:alnum:]_@#%:]+:\\)[ \t]*$" -- 2.7.4 --=-=-= Content-Type: text/plain > As you can see in the diffs above, master-only changes are using 26.1 > for :version. Assuming Org 9.0.* ships with Emacs 26.1, these will be > wrong, but they can be updated all together once 26.2 is released. I have been getting my numbers mixed up. :) Fixed. > Thanks. Did you forget to attach the patch? Yes. :( But not this time! >> I don't know if this still technically qualifies as a tinychange. I've >> sent the email to request the CA form just in case. > > I don't know either. How about I apply your *.el changes, and we can > update ORG-NEWS once your assignment comes through? Sure. Thanks for your patience. Please let me know if any other changes are needed. --=-=-=--