From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id cG1cEb69116YXwAA0tVLHw (envelope-from ) for ; Wed, 03 Jun 2020 15:11:58 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id UDhbDb69116xWAAA1q6Kng (envelope-from ) for ; Wed, 03 Jun 2020 15:11:58 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D8AAA9404C8 for ; Wed, 3 Jun 2020 15:11:57 +0000 (UTC) Received: from localhost ([::1]:38988 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgV3c-0000pm-R5 for larch@yhetil.org; Wed, 03 Jun 2020 11:11:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38256) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgV2l-0000o0-66 for emacs-orgmode@gnu.org; Wed, 03 Jun 2020 11:11:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43193) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgV2k-00066s-4L; Wed, 03 Jun 2020 11:11:02 -0400 Received: from lns-bzn-40-82-251-163-54.adsl.proxad.net ([82.251.163.54]:41992 helo=guerry) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1jgV2i-00045J-CB; Wed, 03 Jun 2020 11:11:01 -0400 Received: by guerry (Postfix, from userid 1000) id 4D7CF1A60817; Wed, 3 Jun 2020 17:10:58 +0200 (CEST) From: Bastien To: stardiviner Subject: Re: [Feature] add a new org-attach dispatcher command to offline save web page Organization: GNU References: <87sgflu2gw.fsf@gmail.com> <87mu5rscg7.fsf@gmail.com> <87y2p51wy0.fsf@gnu.org> <87h7vtbm05.fsf@gmail.com> <87o8q1r1bq.fsf@gnu.org> <87eeqxbkf5.fsf@gmail.com> Date: Wed, 03 Jun 2020 17:10:58 +0200 In-Reply-To: <87eeqxbkf5.fsf@gmail.com> (stardiviner's message of "Tue, 02 Jun 2020 22:40:30 +0800") Message-ID: <87lfl4yykd.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Org Mode Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: 9WkhKnuukw/G Hi, stardiviner writes: > Here is my patch, I try to annotate on my patch code to express my > words: Thanks - I see what is hardcoded and why. Since the whole idea is to use something else than url-copy-file for downloading URLs I would rather add an option to allow using a custom function. Something like `org-attach-url-copy-file-function' which would be url-copy-file by default but could be set to another function with the same signature. Don't rush on implementing this though, I'd like to reread the code in org-attach.el again to decide if this is the right way - and this won't be before 9.5. Best, -- Bastien