From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 6ErvLXwWp2EBCgAAgWs5BA (envelope-from ) for ; Wed, 01 Dec 2021 07:30:20 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id uNB1KXwWp2FPQwAAbx9fmQ (envelope-from ) for ; Wed, 01 Dec 2021 06:30:20 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 457D292B2 for ; Wed, 1 Dec 2021 07:30:20 +0100 (CET) Received: from localhost ([::1]:59122 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1msJ8E-0004eJ-JZ for larch@yhetil.org; Wed, 01 Dec 2021 01:30:18 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53752) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msJ72-0004e9-5C for emacs-orgmode@gnu.org; Wed, 01 Dec 2021 01:29:04 -0500 Received: from [2607:f8b0:4864:20::1033] (port=44773 helo=mail-pj1-x1033.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1msJ70-0002xp-G4 for emacs-orgmode@gnu.org; Wed, 01 Dec 2021 01:29:03 -0500 Received: by mail-pj1-x1033.google.com with SMTP id nn15-20020a17090b38cf00b001ac7dd5d40cso510299pjb.3 for ; Tue, 30 Nov 2021 22:29:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version; bh=BLcBAmMzeYDPdLK26/tcgTkDkhqNvP8DQTiAI7Jymg8=; b=JNZ+rLBqXivAcFpjOfNW5kY61+coF3fHMKyDHqBmZ1lfg77FmPbU5vMC4y00gvnUxl fN+FB4iftbXJv2jT5IjB1Lv/OfqmsvlmKd+2etMS8ZgFnyQYYanPVdjLnBmWz5G42WT2 P7JRhIRgxZeRcty/+fESQ1knRGHgK118BuKI3uKlv6MBoJfuEeXYVI/mG3ClpLfitviu zSqi7zKZZYZt+LyqHVrszcfiUNKn62f0iWyQDRYzOFUspH3ysMkiG5Q2sM6Vdy92WV1K KyoLahX7HuFO+bxGlKZYEVN35UpBjTnlnD8A5JAWFpFNyqclAaFziVvvPrR6dzpcMjM1 UWEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version; bh=BLcBAmMzeYDPdLK26/tcgTkDkhqNvP8DQTiAI7Jymg8=; b=fkGhnSCY24QwnvyZwDI2sL4E0PUm9QlaUmCDfXo0kfotCPdVBQla2RHL82ZkpmmSg4 qTqwM4glx9ODj40yDh1N92fO0uGK5Q3F04Yf64UJGeGJHq9uVcpF6blxcIfsRp41NPuE IN3wE/Pq8XK+Gkptv7kvxLmGKq1Mpvg8G4tDLknMqMaytkXJVGUUpxCDw2m1CLqQPJOo WifZfZz7Amx9fEHWo+Rs2WrySk706hR/epJVhNmK1oNRs1OdAap7XYub1rja4iXl+R01 cxWiugzUXJMq+8XloiKqwG/69iRY57n87B0sDZV5ycLWXQMtCVdXAPmoiK7JMYjgqjzF gKvg== X-Gm-Message-State: AOAM533V8cdv32gJhLjhdJ0cJcfiGA0Rdy+o+lQgvoh30TgCxI7IIETQ i6ySDnH3rWaCveiz7U67xR0hAJyaeio= X-Google-Smtp-Source: ABdhPJy6c8bQuwG1Geh8ssEs9rH6fF2liDHOxJFuPtcLz0yppcjIJ6mbga7+R5BfHOWaxcso6SnBTA== X-Received: by 2002:a17:902:e806:b0:141:fd0a:2201 with SMTP id u6-20020a170902e80600b00141fd0a2201mr4976776plg.48.1638340140474; Tue, 30 Nov 2021 22:29:00 -0800 (PST) Received: from dingbat (2001-44b8-31f2-bb00-a541-f132-a1f3-83b1.static.ipv6.internode.on.net. [2001:44b8:31f2:bb00:a541:f132:a1f3:83b1]) by smtp.gmail.com with ESMTPSA id gv23sm4445501pjb.17.2021.11.30.22.28.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Nov 2021 22:28:59 -0800 (PST) References: <87lf18fue9.fsf@aquinas.i-did-not-set--mail-host-address--so-tickle-me> <87v90cpcdx.fsf@yandex.com> <87ilwcf31l.fsf@aquinas.i-did-not-set--mail-host-address--so-tickle-me> <87pmqjkai3.fsf@gmail.com> <87fsrffknl.fsf@aquinas.i-did-not-set--mail-host-address--so-tickle-me> <87czmijtrp.fsf@gmail.com> <87o861o9sh.fsf@aquinas.i-did-not-set--mail-host-address--so-tickle-me> <87h7btpfbt.fsf@gmail.com> <87zgpli5nc.fsf@gmail.com> User-agent: mu4e 1.7.5; emacs 28.0.60 From: Tim Cross To: Kaushal Modi Subject: Re: [PATCH] Fix org-comment-line-break-function Date: Wed, 01 Dec 2021 17:17:09 +1100 In-reply-to: Message-ID: <87lf14j0t4.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::1033 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::1033; envelope-from=theophilusx@gmail.com; helo=mail-pj1-x1033.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Lawrence , Marco Wahl , emacs-org list , Nicolas Goaziou Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1638340220; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=BLcBAmMzeYDPdLK26/tcgTkDkhqNvP8DQTiAI7Jymg8=; b=Q/Sqz7FUSpbG8IF7DWJuSqxOdG8GhPol8BcNPpqkgqPmsPqU3w0waoCxjxdJW6WmDf5Nfb yNNqEqyUEnUp9XDV3w9qYqeidjSBr+XttWZQGAyZ5PYOxTB9LZYZMdhLOKh64K2Ps3xeqU oxZKr+45Hnh5w9bH1Nxi5Wvh+lysFmUhTW1QexGvmkVoUQzpIAQFrAK97fsCROdLXdaNtJ M4OxE3jHROL/qyR+X5LKtqL9tMTasilHRtcDon5KDinCfx+ph6SkwPnEBxa+EAltVwa7ga IprISmF+FM0KdN3dRuqTgDfIj6rSzQ8s1FYG5XL2GovHuu4PHqJiOlqJQgkT9A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1638340220; a=rsa-sha256; cv=none; b=AUhlWq+DaIchzpCMy6DABjj3ns1I/ogI4DgI7+zii7kLA72bEHXOxK43TBgD4B1Z+8pSGd i602QxpFmewy6oU/mh3Ccsh8daSK0pyWRo5NGxDLKbjo/v1LHPh6Qht30rt+O9cQ9WyNvL 2nPJcdBTp30M195oX2Ho1/wGmE0D4xLWaFI+ZjDLw35b0VaGn3R7QDTjyBLaFbvUeqEBQy 2JewcIRL1nYbIMIxoQxayn0r/CudDhwkourRq4rHEIMMr/7hf7X6S2ptFoPMewnwiXypQo 50uHm4lppj/SGtQ4CJV01snIvhNotAMjut4wAuiXq0bLD6kyrBIU8uD43YgSxQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=JNZ+rLBq; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -0.31 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=JNZ+rLBq; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 457D292B2 X-Spam-Score: -0.31 X-Migadu-Scanner: scn0.migadu.com X-TUID: HBd05kKeTcn0 Kaushal Modi writes: > On Tue, Nov 30, 2021 at 6:29 PM Tim Cross wrote: > > It would be good to get Nicholas' input here as I think he wrote the > original function back in 2012. > > Just to see what happens, I tried this: > > M-: (setq-local comment-line-break-function #'comment-indent-new-line) > > .. and then M-j started working perfectly! It worked fine both: in Org comment lines and out of comment lines. > > I see that comment-indent-new-line was added to emacs in newcomment.el back in 2000. So I don't know why > org-comment-line-break-function was added. May be Nicolas can comment more on that. > > So would this patch work? > Well, that is the big question - why was org-comment-line-break-function added instead of just using the default comment-indent-new-line? My only thoughts are there must be some subtle difference in org which the default function was not sophisticated enough to work with. Problem is, not knowing what that might be makes it hard to test and verify the real impact of making the change. Until this is determined, I think the only 'safe' approach would be to just advise those who are impacted by the M-j issue to set comment-line-break-function to comment-indent-new-line and then wait to see if someone who has more historical context to comment. If nothing or nobody says anything after a couple of months, then maybe apply your patch.